Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Archived threads need to be automatically skipped #242

Closed
ghost opened this issue Aug 14, 2021 · 4 comments
Closed

[Feature request] Archived threads need to be automatically skipped #242

ghost opened this issue Aug 14, 2021 · 4 comments
Labels

Comments

@ghost
Copy link

ghost commented Aug 14, 2021

When threads are archived by the owner or the moderator of the server, the thread cannot be archived.

The Undiscord userscript needs to automatically detect when the user's messages in a thread is archived and automatically skip them, without having to make an attempt to delete and give the user an error message.

At the end of the deletion, users should see if there are still messages left, as they usually do. Obviously the remaining undeleted messages would be from the archived threads, and the user would have an estimate how many messages they left in the server from those archived threads. Alternatively, the script could also state that there were messages that can't be deleted.

I've had many times the Undiscord userscript would try to delete a message, send me back an error message, move onto the next message, and repeat this pattern, making the deletion process a lot slower:

50083

I would like the Undiscord userscript to skip archived threads entirely because messages from archived threads cannot be deleted.

@ghost
Copy link
Author

ghost commented Aug 14, 2021

50083(1)

Another reason: the Undiscord will keep retrying attempts to delete user messages that are in archived threads, making the program run for an infinite amount of time.

@an0nan0nan0n
Copy link

+1 this issue is a huge nuisance

@vctrle
Copy link

vctrle commented Oct 11, 2021

+1 this issue needs immediate attention

@sinnx3
Copy link

sinnx3 commented May 1, 2022

+1 on this. Clogs up the deletion queue especially when 15/25 of search results are from archived threads then on next search pull from the api it requeues those archived posts so it's in a constant loop. Severely impacts deletions.

Edit: [Workaround - if your server has minimal threads, haven't quite figured out how to do for messages with large amounts of threads and messages in-between] Let the script run it's course and copy the oldest thread messageid and set the id for before and restart the deletion scrip then the script will delete messages in mass prior to the archived thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants