Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve generator on AC in 1 start/stop handling #1031

Closed
4 of 6 tasks
vejpasop opened this issue Feb 6, 2023 · 18 comments
Closed
4 of 6 tasks

Improve generator on AC in 1 start/stop handling #1031

vejpasop opened this issue Feb 6, 2023 · 18 comments
Assignees
Milestone

Comments

@vejpasop
Copy link
Collaborator

vejpasop commented Feb 6, 2023

The general recommendation is to wire the generator to AC input 1. The main reason is that when the battery is completely empty or disconnected, a Quattro can only start from AC input 1 and not from AC input 2.

Currently for the generator start/stop option to automatically stop a backup-generator once the grid has returned after an outage the generators is has to be connected to AC in 2

This can be fixed by adding an option to automatically stop the generator when connected to AC input 1. This change will include a feature to first disconnect from the generator, and only thereafter stop it. Making for a much smoother hand-over from generator to inverter mode.
Additionally a (configurable) cool-down and warm up period should be implemented.

todo

  • vebus firmware: Add ability to separately control ignore ac inputs and read back Ac in availability
  • mk2-dbus: Add new dbus items and remove default "generator connected" setting from AC input 2
  • generator-start stop: Implement required functionality
  • Review by Jesus
  • VRM: Decide if we need to do something for VRM
  • Node-RED: Decide if we need to do something for Node-RED.

Mk2-dbus

The following dbus items will be added

  • /Ac/Control/IgnoreAcIn1
  • /Ac/Control/IgnoreAcIn2
  • /Ac/State/AcIn1Available
  • /Ac/State/AcIn2Available

Related issue

#303

@vejpasop
Copy link
Collaborator Author

vejpasop commented Feb 7, 2023

Added to mk2-dbus v3.48

@vejpasop
Copy link
Collaborator Author

vejpasop commented Feb 10, 2023

Added to Multi firmware version 502.
mk2-dbus v3.49 is on the Venus todo.

@izak
Copy link
Collaborator

izak commented Mar 6, 2023

Some teasers.

Settings for warmup/cooldown, in 10-second intervals, up to 10 minutes. Only shown if AC-in is a generator.

Selection_359

Two new states are introduced, Warm-up and Cool-down. In these states, the Quattro is ignoring AC-in-1 to keep the load off. The runtime counter keeps running.

Selection_360

Selection_361

You can now stop the generator when AC-2 is available. Because this is strictly exclusive (you cannot have both stop-on-AC1 and stop-on-AC2 enabled), it is a dropdown selection:

Selection_362

Selection_363

@sdikiy
Copy link

sdikiy commented Mar 7, 2023

It may be worth adding a delay (which can be changed) between when ACin1 or ACin2 is available and when the generator stops.

@KW4NP
Copy link

KW4NP commented Mar 24, 2023

I agree that a delay for changeover might be useful, especially for some of the more unstable grids it's really annoying to have the generator kick on repeatedly. But we're really looking forwards to this feature, so don't delay it to add a delay!

@mpvader mpvader added this to the v3.00 milestone Mar 25, 2023
@mpvader mpvader assigned jepefe and unassigned izak and vejpasop Mar 30, 2023
mpvader added a commit to victronenergy/meta-victronenergy that referenced this issue Apr 27, 2023
Add support for stopping when AC-in-2 available
Add warmup and cooldown cycles
Part of victronenergy/venus#1031
@mpvader mpvader changed the title Vebus: Improve generator on AC in 1 start/stop handling Improve generator on AC in 1 start/stop handling Apr 27, 2023
@jepefe
Copy link
Collaborator

jepefe commented May 8, 2023

I reviewed the code and also ran some tests and all that was working before remains working. Also tested warm-up and cool-down feature, works good too.

@mpvader mpvader assigned izak and unassigned jepefe May 9, 2023
@mpvader
Copy link
Contributor

mpvader commented May 9, 2023

@izak pls initiate the vrm work; once done you can close this issue

@mpvader
Copy link
Contributor

mpvader commented May 9, 2023

Also; does it make sense to have these new mk2dbus in nodered?

And are they documented on the public dbus wiki page? Pls make sure they are; incl that they are used by gen startstop since v3.00; thanks!

@mpvader
Copy link
Contributor

mpvader commented May 12, 2023

Any remaining things here are for v3.10

@mpvader mpvader modified the milestones: v3.00, v3.10 May 12, 2023
@Wholistic
Copy link

A bug report from a large user in the field,

Site has a large 110 kVA generator with its own shutdown circuit which is not working as expected with the Venus generator cooldown timer and 9 x 15 kVA quattros.

Even if they set the controller shutdown to 0 seconds, it still takes 5 seconds or so for the generator to shut itself down after receiving the shutdown signal from the GX relay.

If they set the GX cooldown to 60 seconds, when the Victron cooldown engages it disconnects the AC-input from the generator, then after the 60s time period opens the relay to send the signal to stop the generator.

This sends the generator into its own cooldown mode, which is not immediate, taking 5+ more seconds.

At this point the Quattro still detects AC available on the AC input and then Quattro reconnects, drawing full load 110 kVA for a few seconds.
Then the generator self-shutdown timer finishes and turns itself off.

The opposite of the intended smooth cooldown.

The customer requests that there is an AC-input relay time limit after the cooldown timer before the generator would be allowed to reconnect (prevent immediately re-closing the AC-input relay again).

They believe this current behaviour may have just burned out a feedback relay on their Quattros setup.

Customer can be contacted at support@myenergysolar.com.au

@kwindrem
Copy link
Collaborator

kwindrem commented Jul 4, 2023

I had a user of GuiMods and ExtTransferSwitch report the same problem today. In his case the generator produces voltage for about 2 seconds after the GX relay opens and the AC detection logic in the Multi/Quattro is faster than that!

I think the correct solution is to add a user configurable "post cool-down delay" that extends the ignore AC input for that period after cool-down ends and the generator is stopped.

Is this an issue which Victron intends to address rapidly? If not, I'll make an addition to my code until it does get implemented.

@mpvader
Copy link
Contributor

mpvader commented Jul 4, 2023

Hi both, thank you for reporting.

Is this an issue which Victron intends to address rapidly? If not, I'll make an addition to my code until it does get implemented.

yes.

does it need to be configurable? I’d prefer adding a hardcoded number; like 10 seconds or something.

@kwindrem
Copy link
Collaborator

kwindrem commented Jul 4, 2023

My only thought was if a generator had it's own cool-down period that was not adjustable, any hard coded delay used in the GX device might not be enough.

If any generator cool-down period can be set to zero or a few seconds, then a hard coded value should be sufficient. I'm doing exactly that right now for GuiMods/ExtTransferSwitch. I picked a delay of 15 seconds. I'll change that to whatever fixed delay Victron decides on or pick up a user-configurable value if that happens.

@Wholistic
Copy link

Wholistic commented Jul 4, 2023

In this case a 30 second hard wired delay before allowing ac input again would resolve it, and be the fastest remedy as it wouldn't require any extra UI work.

I think that's the best fix, and then see if any additional issues emerge before putting any more time into it.

I guessed 30s, but I really don't know. 60s seems a bit long, 10s maybe a bit short.

izak added a commit to victronenergy/dbus_generator that referenced this issue Jul 13, 2023
It turns out that some generators takes a long time
to respond to the instruction to switch off. When cooldown is
configured, the Multi is instructed to ignore AC-in while the
generator cools down, and AC-in is un-ignored once the generator
is stopped.

If the generator takes too long to stop, however, AC-in may
be re-engaged before the generator stops. To avoid this,
there is now a 15 second delay to allow the generator
to stop cleanly.

victronenergy/venus#1031
jhofstee added a commit to victronenergy/meta-victronenergy that referenced this issue Jul 17, 2023
Add a Stopping state: 15-seconds after stopping the genset, before
re-enabling AC-in. This prevents a condition where a slow-stopping
generator may be re-engaged after the cool-down period, before the
generator stops.

victronenergy/venus#1031
@mpvader
Copy link
Contributor

mpvader commented Jul 17, 2023

Per v3.10~17 we added a 15 second hard wired delay.

@mpvader
Copy link
Contributor

mpvader commented Aug 30, 2023

Closing.

Most of this issue was implemented in v3.00 by the way.

and some bug fixing in v3.10

@mpvader mpvader closed this as completed Aug 30, 2023
@Wholistic
Copy link

A new bug report for a customer where the hard coded 15 seconds was not long enough.
https://community.victronenergy.com/questions/240918/need-multiplus-to-ignore-generator-ac-during-cool.html

@mpvader
Copy link
Contributor

mpvader commented Nov 6, 2023

Continues in a new issue: #1171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants