Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbus-modbus-client: Add Comap support #1055

Closed
5 tasks done
dirkjanfaber opened this issue Mar 31, 2023 · 4 comments
Closed
5 tasks done

dbus-modbus-client: Add Comap support #1055

dirkjanfaber opened this issue Mar 31, 2023 · 4 comments
Assignees

Comments

@dirkjanfaber
Copy link
Collaborator

dirkjanfaber commented Mar 31, 2023

Add support for the Comap CM Ethernet module. For example in combination with the InteliLite 4 AMF 25.

On the Comap side, first the MODBUS server needs to be enabled (via the Setpoints -> CM-Ethernet -> MODBUS settings)

image

TODO

  • Add comap driver to dbus-modbus-client
  • Log relevant new values to VRM
  • modbustcp for some new paths
  • dbus-generator-starter
  • Adapt GUI pages currently used for FischerPanda to be more generic and reusable for ComAp
@izak
Copy link
Collaborator

izak commented Apr 12, 2023

Dbus paths for comap:

Paths common to other .genset services

/NrOfPhases    ->  1, 2 or 3 for single-phase, split-phase and 3-phase respectively
/Ac/Power      -> Total AC power rounded to the nearest Kilowatt (Comap controller supports no more accuracy)
/Ac/L1/Power   -> Per phase power values to the nearest Kilowatt
/Ac/L2/Power
/Ac/L3/Power
/Ac/Frequency   -> AC Frequency, to 0.1Hz
/Ac/L1/Voltage  -> Per phase voltages to the nearest 1V
/Ac/L2/Voltage
/Ac/L3/Voltage
/Ac/L1/Current  -> Per phase current to the nearest 1A
/Ac/L2/Current
/Ac/L3/Current
/Ac/Energy/Forward -> Produced energy in kWh

Paths specific to comap, some in common with FischerPanda:

/Engine/Speed                -> Engine speed in RPM 
/Engine/CoolantTemperature   -> Engine coolant temperature
/Engine/OilPressure          -> Engine oil pressure
/Engine/Load                 -> Engine load as a percentage
/Engine/OperatingHours       -> Operating hours, to the nearest 0.1 hours.
/StarterVoltage              -> Voltage of starter battery
/FuelLevel                   -> Fuel level as a percentage; on HG195 trailer this always showed invalid
/StatusCode                  -> Enum, re-uses and maps the one previously made for FischerPanda.

Paths NOT implemented

/ErrorCode    -> FischerPanda has 166 error codes. Comap has no such register at all.

Status code

This is identical to the existing values used for FischerPanda

Value Meaning
0 Stopped / Ready
1 Self-test
2 Preheat (glow-plugs on Diesel engine)
3 Starting
8 Running
9 Stopping
10 Error (not ready to start, or controller is in Emergency Manual mode)

izak added a commit to victronenergy/dbus-modbus-client that referenced this issue Apr 12, 2023
@mpvader
Copy link
Contributor

mpvader commented Apr 12, 2023

Hey @izak , nice thanks. Do you still have the service interval (hours or minutes) on your radar?

izak added a commit to victronenergy/dbus_modbustcp that referenced this issue May 26, 2023
Add registers for fuel level and oil pressure. Currently only
available on the ComAp-controllers.

victronenergy/venus#1055
mpvader added a commit to victronenergy/meta-victronenergy that referenced this issue Jun 3, 2023
Add support for ComAp-based gensets.
victronenergy/venus#1055
mpvader added a commit to victronenergy/meta-victronenergy that referenced this issue Jun 3, 2023
Migrate FischerPanda specific settings to also accommodate other
gensets, by renaming FischerPanda0 to Generator1.

victronenergy/venus#1055
mpvader added a commit to victronenergy/meta-victronenergy that referenced this issue Jun 3, 2023
Add support for ComAp-based Gensets

More broadly, it adds support for any genset with a
com.victronenergy.genset service.

This generalises the existing FischerPanda support for other generators.

victronenergy/venus#1055
@izak izak closed this as completed Jul 28, 2023
@Pye-lmk-power
Copy link

Are you working with the DSE8610 or DEif AGC150?

@philipptrenz
Copy link
Collaborator

Hi @Pye-lmk-power, these GitHub issues are primarily to organize development work. A better place for you questions is here: https://community.victronenergy.com

In short: We already support the DSE 8610 MKII controller. Support for DSE 8610 can be added, if someone provides us with access to such a system for testing. Regarding DEIF AGC150: I can confirm, that we're currently looking into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants