Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlashMQ reconnect issue and triggered dbus-flashmq VRM registration race condition #1269

Closed
wiebeytec opened this issue May 14, 2024 · 1 comment
Assignees
Milestone

Comments

@wiebeytec
Copy link
Collaborator

wiebeytec commented May 14, 2024

A bridge reconnect issue (triggered under certain circumstances) was found in FlashMQ. Fix has been written, extra testing underway.

A situation that can subsequently arise, is that of two bridges, one is connected and the other is not, which triggers a bug in dbus-flashmq where the connection state $SYS topic updates of those bridges race with each-other and keep redoing the VRM token registration (which is an action done on disconnect normally).

@wiebeytec wiebeytec added this to the v3.40 milestone May 14, 2024
@wiebeytec wiebeytec self-assigned this May 14, 2024
wiebeytec added a commit to victronenergy/dbus-flashmq that referenced this issue May 15, 2024
When one bridge was connected and the other one wasn't, the MQTT topics
for connection status signalled 1 and 0 respectively. This caused it
consider it a 'connection/disconnection' event.

This fixes installations continously registering at VRM when one bridge
was connected and the other wasn't.

victronenergy/venus#1269
@wiebeytec
Copy link
Collaborator Author

FlashMQ 1.13.0 fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant