Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemcalc: Don't show systemstate when ESS mode is external control (mode 3) #1270

Closed
1 task done
izak opened this issue May 14, 2024 · 0 comments
Closed
1 task done
Assignees

Comments

@izak
Copy link
Collaborator

izak commented May 14, 2024

The systemstate indicator, the # codes shown on the overview, still attempt to show the system state when external control is used. This sometimes causes confusion, especially when #2 shows up while BatteryLife is obviously not in play. This happens because the BatteryLife state machine still remembers what state it was in before the mode was changed to External Control.

The best solution is simply not to attempt to determine a system state when ESS mode is set to External Control. The reason codes are there so users can understand why the system is doing what it is doing, and during External control, the system is per definition not doing its normal thing, someone else is.

TODO

  • Don't show system state if ESS mode is External Control
@izak izak self-assigned this May 14, 2024
izak added a commit to victronenergy/dbus-systemcalc-py that referenced this issue May 21, 2024
When ESS mode is set to 3 (external control), don't show a system
state. Otherwise it will sometimes show ESS reason codes that
make no sense.

victronenergy/venus#1270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant