Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemcalc: visualisation of an ESS system with multi off has issues #806

Closed
mpvader opened this issue Mar 29, 2021 · 4 comments
Closed
Assignees

Comments

@mpvader
Copy link
Contributor

mpvader commented Mar 29, 2021

two issues.

First, the grid meter doesn't show properly anymore:

image

while there is still data from it:

image

And a little bit later, when the Multi is switched off, it shows this, which is also wrong:

image

most likely what above picture should do is: (a) show those loads connected directly to AC in, (b) still show critical loads, like two pictures up, (c) still show the ac input

@mpvader mpvader changed the title systemcalc: in an ESS system with multi off has issues systemcalc: visualisation of an ESS system with multi off has issues Mar 29, 2021
@mpvader
Copy link
Contributor Author

mpvader commented Mar 29, 2021

also the VRM looks strange. In a slightly different way though. see screenshot below. And note how left and right are different.

Probably step 1 is to fix dbus-systemcalc to show the info in the proper way, issue is probably that it no longer sees an ESS Assistant.

And then step 2 is to get gui and vrm to use the data properly, if they don't already do that.

image

@izak
Copy link
Collaborator

izak commented Mar 30, 2021

The reason why the grid meter value is not used when the Multi is off, is because the GUI decides which value to show in that box based on the active AC input, and when the Multi is off it doesn't know. So even though grid value is there, it doesn't know whether it can use it. This logic is in the GUI.

izak added a commit to victronenergy/dbus-systemcalc-py that referenced this issue May 27, 2021
 - Make an educated guess towards whether grid/shore or generator is active
   - If the Multi is on/connected, use ActiveInput
   - If Multi is off/disconnected, guess based on presence of grid/genset meter
 - By moving this logic into systemcalc, it can be removed from the GUI
 - This also allows relevant information to be displayed when the Multi is off
   or if AC-in is disconnected for some reason, eg relay assistant.

victronenergy/venus#806
izak added a commit to victronenergy/dbus-systemcalc-py that referenced this issue May 27, 2021
When turning a Multi off, the default machinery considers it disconnected. There is however
enough data left on the service to determine whether it is an ESS system. Therefore we override
the default implementation and check the service directly to determine the hub type.

This fixes:
 - System type is no longer indicated as Hub-1 when you turn off the Multi.
 - The overview does not change when the Multi is turned off
 - The critical loads block on the GUI remains visible

victronenergy/venus#806
@izak
Copy link
Collaborator

izak commented May 27, 2021

Discussion of implementation to date.

  1. Systemcalc publishes three new values corresponding to the active AC input. Therefore the GUI no longer needs its own logic and can simply use these values from systemcalc.
  2. Systemcalc can make an intelligent decision based on the availability of a grid or genset service, and publish suitable information even when the Multi is off.
  3. Fix the hubtype indication in systemcalc, so that the GUI doesn't change to a different overview (losing the Critical Loads block). This also fixes another irritation: Switching the Multi off causes the Tiles view to show "Hub-1", which is obviously wrong.

jhofstee added a commit to victronenergy/meta-victronenergy that referenced this issue Jul 9, 2021
….74 & v2.75

Add full DVCC support for Inverter RS, including CVL, CCL, SVS, STS and SCS.
Closes victronenergy/venus#803
Implement logic for ActiveAcIn in systemcalc so it can move out of the GUI
    Fix problem where grid meter reading disappears from GUI when Multi is off
Fix hubtype indication
    Turning off a Multi in an ESS system would cause hubtype to change to Hub-1
    Overview would change and Critical Loads block would disappear when turning off Multi.
    victronenergy/venus#806
Improve System State display
    In system without a Multi but w* dbus-generator v1.4.0 & v1.4.1
Update to python3
Fix unit tests broken since Venus 2.70.ith a managed battery, show when discharge is
    allowed/disallowed by battery
Support for Lynx Smart BMS (Backported to 2.72~2 as patch)
    Stop all chargers when CCL=0 (charge current limit) is received.
Switch off inverters when DCL=0 (discharge current limit) is received from a managed battery
    For Inverter RS, copy the the DCL to the inverter. Firmware 1.04 switches off inverter.
    For other inverters (not Multis), switch the inverter off by setting Mode to Off.
    victronenergy/venus#736
Fix possible crash when non-ascii character used in battery measurement name
    No actual cases found, part of a wider unicode cleanup
Clean up BMS selection where there is another battery monitor in the system
    Since Venus 2.30, it is possible to set the battery monitor to a BMV, but still use the
    charge parameters from a BMS in the system.
    This hidden functionality is not shown anywhere, so instead remove it and make it simpler.
    victronenergy/venus#783
Force DVCC settings for pylontech batteries
    Set this as the documentation already advises: DVCC=on, SVS=off, STS=off.
    victronenergy/venus#784
Upgrade to Python3
@izak
Copy link
Collaborator

izak commented Aug 13, 2021

Fixed as of Venus v2.80~10.

@izak izak closed this as completed Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants