Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up PV Voltage, Current and Power paths on D-Bus #847

Closed
9 tasks done
mpvader opened this issue Aug 19, 2021 · 1 comment
Closed
9 tasks done

Clean up PV Voltage, Current and Power paths on D-Bus #847

mpvader opened this issue Aug 19, 2021 · 1 comment
Assignees
Milestone

Comments

@mpvader
Copy link
Contributor

mpvader commented Aug 19, 2021

This change was put in motion due to some differences between how vedirect-interface puts the tracker info on the D-Bus, and how vecan-dbus does it; also vrmlogger didn't transmit the Watts per tracker. Instead it transmitted Volts & Amps; which seems ok at first, but when you think about it its wrong: the main number here are the watts; and when a small current is rounded to 0, then suddenly Watts is reported as 0 while its not 0.

Also, after taking a closer look, and knowing that signal-changes on D-Bus heavily affect cpu load and thus scalability wrt max number of devices, we decided to take the /Pv/I away. UIs can self-calculate that, by simply dividing the power by the voltage.

The vrmlogger issue, now solved, was causing issues on the VRM Dashboard at the moment, where Teun is trying to get all trackers visual in the detailed box.

Todo list:

  • (mva) update our dbus wiki page.
  • (ibu) vrmlogger needs changing to report Voltage & Power for those two trackers (backport candidate for v2.73)
  • (tve) remove the paths for PV current: /Pv/x/I, as well as the far longer existing /Pv/I.
  • (mbo) check that dbus-vecan is in sync, also for the Inverter RS (which is now no longer supported by vedirect-interface!)
  • (mva) arrange the VRM Advanced graphs to calculate current rather than take it from the database.
  • (tve) fix up the relevant pages in the gui/qml.
  • (dfa) update node-red nodes for this
  • (ibu) remove /Pv/I from vrmlogger
  • (ibu) check if we need to do something with modbus-tcp; or some other consumer that I'm now forgetting

System to test this on:
https://vrm.victronenergy.com/installation/55013/overview

vedirect-interface:

image

vecan-dbus:

image

vrmlogger:

image

@mpvader mpvader added this to the v2.80 milestone Aug 19, 2021
@izak izak removed their assignment Sep 3, 2021
@mpvader mpvader changed the title Fix up reporting per tracker (for the RS) Clean up PV Voltage, Current and Power paths on D-Bus Sep 13, 2021
izak added a commit to victronenergy/dbus_modbustcp that referenced this issue Sep 21, 2021
Individual current values have been removed from MPPT trackers
and inverter RS in favour of power values. So remove the
current values and add power values instead.

victronenergy/venus#847
@martinbosma martinbosma assigned martinbosma and unassigned jhofstee Nov 1, 2021
@mpvader
Copy link
Contributor Author

mpvader commented Dec 15, 2021

All done, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants