Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression on streams with timestamp/playlist drift in "0.7.10" #1265

Closed
doublex opened this issue Jul 18, 2017 · 7 comments
Closed

Regression on streams with timestamp/playlist drift in "0.7.10" #1265

doublex opened this issue Jul 18, 2017 · 7 comments

Comments

@doublex
Copy link

doublex commented Jul 18, 2017

This hls-stream:

http://doppelbauer.name/u/master.m3u8

Works in "0.7.9":

http://streambox.fr/mse/hls.js-0.7.9/demo/?src=http%3A%2F%2Fdoppelbauer.name%2Fu%2Fmaster.m3u8

In "0.7.10" it stops after 46 seconds:

http://streambox.fr/mse/hls.js-0.7.10/demo/?src=http%3A%2F%2Fdoppelbauer.name%2Fu%2Fmaster.m3u8
@radiantmediaplayer
Copy link
Collaborator

Can you try with 0.7.11 and fill the issue template so that we can more easily try to reproduce it.

@doublex
Copy link
Author

doublex commented Jul 20, 2017

Same (but the regression was between 0.7.9 and 0.7.10)

http://streambox.fr/mse/hls.js-0.7.11/demo/?src=http%3A%2F%2Fdoppelbauer.name%2Fu%2Fmaster.m3u8

@mangui
Copy link
Member

mangui commented Aug 7, 2017

introduced by 198922c

there are large enough drifts on this playlist. the hardcoded delay might need to be adjusted or the logic should be reviewed.

@doublex
Copy link
Author

doublex commented Aug 7, 2017

@mangui
Thanks a lot!
Does the the "hardcoded delay" mean:
a) A video-encoding property is bad
b) A property of the HLS server is bad
c) An issue in "hls.js"

@mangui
Copy link
Member

mangui commented Aug 7, 2017

playlist signals fragments with duration 3s,5s,10s,10s,10s,...
whereas parsed fragments have the following duration : 16.6s,16.6s, 16.6s, ...

in 0.7.11 a specific logic has been introduced to cope with PTS drift : if a drift of more than 10s is observed then timestamp reference is reseted. this does not work with your stream. I might need to review the logic there. but your frag duration signaling is obviously wrong.

@doublex
Copy link
Author

doublex commented Aug 11, 2017

@mangui
Thanks a lot!
You are right, the second keyframe comes after 16.6s...
Would it be possible to add a paramter to change the 10s default?

If not, no problem. Should I close this issue?

mangui added a commit that referenced this issue Aug 19, 2017
it was introduced to overcome a stream capture limitation in #1172
related to #1265
mangui added a commit that referenced this issue Aug 19, 2017
@mangui
Copy link
Member

mangui commented Aug 19, 2017

@doublex it should be fixed. you can grab the last dist and recheck

@mangui mangui changed the title Regression in "0.7.10" Regression on streams with timestamp/playlist drift in "0.7.10" Aug 28, 2017
@doublex doublex closed this as completed Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants