-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed captions are not being rendered in v1.0.7 for encrypted HLS stream. Same is not issue in v0.14.17 version of hls.js #4182
Comments
I found the bugs, but I don't have time to do PR.
Without the fragment hls.js/src/controller/subtitle-stream-controller.ts Lines 396 to 399 in 3975bde
fix
This condition will only work with the 0.14.7 version, which calls the function directly after hls.js/src/controller/timeline-controller.ts Lines 468 to 472 in 6d636d2
Data takes two types hls.js/src/controller/timeline-controller.ts Line 446 in 6d636d2
You have to separate the two types. For example
|
@phloxic You can provide a stream on a server without cros / domain verification
|
Maybe #4530 plays a small part in this too. |
What version of Hls.js are you using?
v1.0.7
What browser (including version) are you using?
Chrome v92.0.4515.107 (Official Build) (64-bit), also all other major browsers Edge, FF etc.
What OS (including version) are you using?
Windows 10
Test stream
No response
Configuration
Additional player setup steps
No response
Checklist
Steps to reproduce
While using the encrypted HLS stream (AES-128), closed captions (webvtt) are not being rendered by the latest version of hls.js i.e. v1.0.7.
This issue is not present with v0.14.17 of hls.js
Also latest version 1.0.7 of hls.js is able to render the closed captions if the HLS is not encrypted.
Please see below screenshot which shows the vtt related m3u8's being downloaded, however player is not requesting the respective vtt requests.
Expected behaviour
While using the HLS encryption (AES-128), along with Closed captions (webvtt), the hls.js player should render the closed captions.
This is working as expected in v0.14.17 version of hls.js
What actually happened?
we tried to upgrade hls.js from v0.14.17 to latest v1.0.7 and we encountered this issue while doing sanity
Console output
Chrome media internals output
No response
The text was updated successfully, but these errors were encountered: