Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - encrypted vtt subtitles not rendered #4554

Merged
merged 272 commits into from
Feb 10, 2022

Conversation

mtoczko
Copy link
Collaborator

@mtoczko mtoczko commented Feb 10, 2022

This PR will...

Fixes the key loading in subtitle-stream-controller.
Improves handling of encrypted fragments in timeline-controller

Why is this Pull Request needed?

Are there any points in the code the reviewer needs to double check?

Resolves issues:

#4182 #4293

stream test: https://d12zt1n3pd4xhr.cloudfront.net/dev/aes-subs.m3u8

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

dependabot bot and others added 30 commits November 3, 2020 07:02
…esdoc-standard-plugin-0.3.1

Bump @itsjamie/esdoc-standard-plugin from 0.3.0 to 0.3.1
Bumps [eslint](https://github.com/eslint/eslint) from 7.12.0 to 7.12.1.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.12.0...v7.12.1)

Signed-off-by: dependabot[bot] <support@github.com>
…per-module-imports-7.12.5

Bump @babel/helper-module-imports from 7.12.1 to 7.12.5
…li-4.2.0

Bump webpack-cli from 4.1.0 to 4.2.0
Bumps [netlify-cli](https://github.com/netlify/cli) from 2.67.2 to 2.67.4.
- [Release notes](https://github.com/netlify/cli/releases)
- [Changelog](https://github.com/netlify/cli/blob/master/CHANGELOG.md)
- [Commits](netlify/cli@v2.67.2...v2.67.4)

Signed-off-by: dependabot[bot] <support@github.com>
…li-2.67.4

Bump netlify-cli from 2.67.2 to 2.67.4
Bumps [netlify-cli](https://github.com/netlify/cli) from 2.67.4 to 2.68.0.
- [Release notes](https://github.com/netlify/cli/releases)
- [Changelog](https://github.com/netlify/cli/blob/master/CHANGELOG.md)
- [Commits](netlify/cli@v2.67.4...v2.68.0)

Signed-off-by: dependabot[bot] <support@github.com>
…li-2.68.0

Bump netlify-cli from 2.67.4 to 2.68.0
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.0.3 to 4.0.5.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v4.0.3...v4.0.5)

Signed-off-by: dependabot[bot] <support@github.com>
…t-4.0.5

Bump typescript from 4.0.3 to 4.0.5
Bumps [eslint](https://github.com/eslint/eslint) from 7.12.1 to 7.13.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.12.1...v7.13.0)

Signed-off-by: dependabot[bot] <support@github.com>
…t-eslint/parser-4.7.0

Bump @typescript-eslint/parser from 4.6.1 to 4.7.0
Bumps [eslint-plugin-standard](https://github.com/standard/eslint-plugin-standard) from 4.0.2 to 4.1.0.
- [Release notes](https://github.com/standard/eslint-plugin-standard/releases)
- [Commits](standard/eslint-plugin-standard@v4.0.2...v4.1.0)

Signed-off-by: dependabot[bot] <support@github.com>
…ugin-standard-4.1.0

Bump eslint-plugin-standard from 4.0.2 to 4.1.0
…t-eslint/eslint-plugin-4.7.0

Bump @typescript-eslint/eslint-plugin from 4.6.1 to 4.7.0
…ha-8.0.4

Bump @types/mocha from 8.0.3 to 8.0.4
Bumps [babel-loader](https://github.com/babel/babel-loader) from 8.1.0 to 8.2.1.
- [Release notes](https://github.com/babel/babel-loader/releases)
- [Changelog](https://github.com/babel/babel-loader/blob/main/CHANGELOG.md)
- [Commits](babel/babel-loader@v8.1.0...v8.2.1)

Signed-off-by: dependabot[bot] <support@github.com>
…der-8.2.1

Bump babel-loader from 8.1.0 to 8.2.1
Bumps [netlify-cli](https://github.com/netlify/cli) from 2.68.0 to 2.68.3.
- [Release notes](https://github.com/netlify/cli/releases)
- [Changelog](https://github.com/netlify/cli/blob/master/CHANGELOG.md)
- [Commits](netlify/cli@v2.68.0...v2.68.3)

Signed-off-by: dependabot[bot] <support@github.com>
…li-2.68.3

Bump netlify-cli from 2.68.0 to 2.68.3
Bumps [netlify-cli](https://github.com/netlify/cli) from 2.68.3 to 2.68.4.
- [Release notes](https://github.com/netlify/cli/releases)
- [Changelog](https://github.com/netlify/cli/blob/master/CHANGELOG.md)
- [Commits](netlify/cli@v2.68.3...v2.68.4)

Signed-off-by: dependabot[bot] <support@github.com>
…li-2.68.4

Bump netlify-cli from 2.68.3 to 2.68.4
github-actions bot and others added 21 commits February 11, 2021 06:21
…lugin-promise-4.3.1

build(deps-dev): bump eslint-plugin-promise from 4.2.1 to 4.3.1
Bumps [mocha](https://github.com/mochajs/mocha) from 8.2.1 to 8.3.0.
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md)
- [Commits](mochajs/mocha@v8.2.1...v8.3.0)

Signed-off-by: dependabot[bot] <support@github.com>
build(deps-dev): bump mocha from 8.2.1 to 8.3.0
…ugin-proposal-optional-chaining-7.12.16

build(deps-dev): bump @babel/plugin-proposal-optional-chaining from 7.12.13 to 7.12.16
…re-7.12.16

build(deps-dev): bump @babel/core from 7.12.13 to 7.12.16
…eset-env-7.12.16

build(deps-dev): bump @babel/preset-env from 7.12.13 to 7.12.16
…eset-typescript-7.12.16

build(deps-dev): bump @babel/preset-typescript from 7.12.13 to 7.12.16
Bumps [eslint](https://github.com/eslint/eslint) from 7.19.0 to 7.20.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.19.0...v7.20.0)

Signed-off-by: dependabot[bot] <support@github.com>
….20.0

build(deps-dev): bump eslint from 7.19.0 to 7.20.0
…pt-eslint/parser-4.15.1

build(deps-dev): bump @typescript-eslint/parser from 4.15.0 to 4.15.1
…pt-eslint/eslint-plugin-4.15.1

build(deps-dev): bump @typescript-eslint/eslint-plugin from 4.15.0 to 4.15.1
@mtoczko
Copy link
Collaborator Author

mtoczko commented Feb 10, 2022

Hi @phloxic
I'll pin your stream as a test in PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants