add support for #EXT-X-PROGRAM-DATE-TIME #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| totalduration += duration; | ||
| byteRangeStartOffset = null; | ||
| programDateTime = null; |
There was a problem hiding this comment.
just a thought, if programDateTime is defined you could also increment it with frag duration to get a relevant date for subsequent frags
There was a problem hiding this comment.
that's probably what it should do. the lib i used to generate m3u8s only includes ext-x-program-date-time tag @ start of playlist or discontinuities. so seems to assume you can compute using durations from there.
i was just using video.currentTime to offset but if we maintain it w/ frag i could just use that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.