(misc) Removing IE8-specific (dead) vtt/cue code #2128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 6, 2021
1 task
This was referenced Aug 13, 2022
1 task
This was referenced Nov 4, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
... remove IE8 specific handling in VTT/Cue related code. It's essentially dead because we don't support Internet Explorer 8, minimum supported version is 11.
Why is this Pull Request needed?
No need for it to stay within the distributable bundle
hls.min.jsbefore:225,970byteshls.min.jsafter:225,822bytesTotal:
-148bytes ⬇️Are there any points in the code the reviewer needs to double check?
Not that I'm aware of
Resolves issues:
None in particular
Checklist
[ ] new unit / functional tests have been added (whenever applicable)N/A[ ] API or design changes are documented in API.mdN/A