-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cue position alignment by adding 50 for Firefox #2229
Conversation
The default value for cue positions must have changed at some Firefox version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Briefly tested this out with some assets with subtitles. It works fine in Firefox without this browser-specific compensation.
However, the clamping rule (0-100) is still enforced by the browser(s). From my testing on Firefox 66 and Chrome 73, both throw exceptions when setting position
out of that range.
It would be nice to know more about this Firefox-specific compensation.. @johnBartos do you have any details to share there? You were the last one to make a change in this code: b7f8468 - by adding the clamp 0 <-> 100
Please follow: video-dev#2229
@michaelcunningham19 It looks like this code should have never been committed as such: jwplayer#87. We removed this from our fork long ago, but neglected to upstream that PR. Thanks for fixing this @mackode |
This PR will...
Remove IMO unnecessary cue position alignment.
Why is this Pull Request needed?
Cues are wrongly positioned in current Firefox. Why we use const (50) for Firefox?
Are there any points in the code the reviewer needs to double check?
Yes, if we keep backward compatibility, maybe this is still needed on older Firefoxes.
Resolves issues:
Checklist