Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Firefox code that shifts captions to the side #87

Merged
merged 1 commit into from
Apr 28, 2017

Conversation

jw-kaurand
Copy link

What does this Pull Request do?

It removes Firefox specific code that shifts captions to the side unnecessarily

Why is this Pull Request needed?

Because captions were being shifted very far to the side unnecessarily. The clamping code that was added previously should protect against any positions that would cause errors in firefox anyways.

Are there any points in the code the reviewer needs to double check?

No

Are there any Pull Requests open in other repos which need to be merged with this?

jwplayer/jwplayer#2024 is somewhat related

@egreaves egreaves merged commit 4839c59 into master Apr 28, 2017
@jwplayer-robot
Copy link

Caution when merging! Automated tests either failed or had an error. Please confirm stable build before merging. commit 13c69a2 http://jenkins.jwplayer.com/job/jw7-pr-builder-hlsjs/172/

Triggered Jobs: jw7_commercial

http://player-pr-test-jenkins.longtailvideo.com/builds/6883/archive/test/squash/bootstrap.html?primary=html5&edition=ads&feature=hlsjs/hlsjs_basic

Get some ☕

@robwalch robwalch deleted the bugfix/firefox-cue-positioning branch January 27, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants