Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audio demuxer contiguity with segments not carrying ID3 timestamps #4847

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Aug 14, 2022

This PR will...

  1. Fix audio demuxer contiguity with segments not carrying ID3 timestamps
  2. Clear audio stream controller waiting for init PTS data when loading state is reset
  3. Fix progressive mode contiguity mux flag

Why is this Pull Request needed?

  1. Audio segments missing ID3 timestamps were assigned incorrect start times and not appended correctly.
  2. When seeking in streams with discontinuities while waiting for video to load in the previous discontinuity for the first time, processing of audio segments was not handled correctly.
  3. When "progressive" mode was enabled, the transmuxer was reset on each chunk loaded leading to gaps in appended video.

Resolves issues:

Fixes #4835

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.2.1 milestone Aug 14, 2022
@robwalch robwalch force-pushed the bugfix/audio-track-contiguity branch from 6f94bf0 to fc3d92d Compare August 15, 2022 22:49
Clear audio stream controller waiting for init PTS data when loading state is reset
Fixes #4835
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HLS.js play failed with the AAC audio stream for v1.2
1 participant