-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream playback fails with hls.js 1.2.4, works in 1.2.1 #5002
Comments
I don't think so. TS* segments do not depend on ID3 for timing.
*But maybe you can provide a little more information about your stream? The segments have ".ts" extension but they do not all start with TS packets. Why are there additional bytes before the TS packets? This change made TS detection much more strict which caused the regression: |
Duplicates #4922 (although in that case it looks like the files are masquerading as JPEG so as to avoid detection as media files on cloudfront) |
Fixes #4922 #5002 Addess comment #5001 (comment)
Fixes #4922 #5002 Addess comment #5001 (comment)
Fixes #4922 #5002 Addess comment #5001 (comment)
Fixes #4922 #5002 Addess comment #5001 (comment)
thank you so much for fixing it, Rob! I will ask our streaming infra team to investigate what is causing those unexpected packets in .ts files. As far as I know they use one of the standard settings in AWS MediaConvert, so it might be that the problem is how MediaConvert treating certain incoming material. |
What version of Hls.js are you using?
v1.2.4
What browser (including version) are you using?
106.0.5249.119 (Official Build) (arm64)
What OS (including version) are you using?
MacOS 12.6
Test stream
https://dg-playback-tests.s3.eu-central-1.amazonaws.com/DEA282151608/master.m3u8
Configuration
Additional player setup steps
No response
Checklist
Steps to reproduce
Expected behaviour
Video intitializes correctly and plays.
What actually happened?
The playback isn't possible with the hls.js versions
1.2.2
and1.2.4
:https://hls-js.netlify.app/demo?src=https%3A%2F%2Fdg-playback-tests.s3.eu-central-1.amazonaws.com%2FDEA282151608%2Fmaster.m3u8&demoConfig=eyJlbmFibGVTdHJlYW1pbmciOnRydWUsImF1dG9SZWNvdmVyRXJyb3IiOnRydWUsInN0b3BPblN0YWxsIjpmYWxzZSwiZHVtcGZNUDQiOmZhbHNlLCJsZXZlbENhcHBpbmciOi0xLCJsaW1pdE1ldHJpY3MiOi0xfQ==
Important: The video stream works as expected with the hls.js
1.2.1
and the native HLS player in Safari, so it looks like a regression issue.Console output
Chrome media internals output
No response
The text was updated successfully, but these errors were encountered: