Fix consistency of FRAG_CHANGED and LEVEL_SWITCHED events #5085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix consistency of FRAG_CHANGED and LEVEL_SWITCHED events after seeking back (#5077)
and update source of
currentLevelgetter prior to emitting these events (#5082)Why is this PR needed:
The player uses the fragment-tracker's
activeFragment.appendedPTSingetAppendedFragto determine which fragment (and level) is currently playing. The method for updatingappendedPTSonly worked when playing and buffering media forward; If segments were appended ahead of the current one,appendedPTSwould be assigned a value outside the segment's range. The method also used TimeRanges from alternate buffers, andappendedPTSwas being set on alt audio segments even though it is never used on them.Resolves issues:
Fixes #5077
Checklist