Prevent ADTS probe false positives when bytes following ID3 are a match for MPEG audio #5783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch for MPEG audio Fixes #5782
robwalch
force-pushed
the
bugfix/mp3-probe-fix
branch
from
db45904
to
c7e408d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Prevent ADTS probe false positives when bytes following ID3 are a match for MPEG audio
Why is this Pull Request needed?
TS/ADTS/MP3 probe methods scan through all or most bytes to find a sync word, and as a result sometimes find a false positive. We tried removing this in v1.2.x, but users with malformed content (media segments starting with JPEG bytes) reported that they depended on it this functionality so it was kept in (#5002).
Are there any points in the code the reviewer needs to double check?
Resolves issues:
Fixes #5782
Checklist