Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support of skip directive without block reload #5791

Merged
merged 1 commit into from Sep 1, 2023

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Aug 31, 2023

This PR will...

Fix support of skip directive without block reload.

Why is this Pull Request needed?

Playlist request directives are only being added when SERVER-CONTROL contains CAN-BLOCK-RELOAD=YES.

Regressed in v1.4.0 with:

Are there any points in the code the reviewer needs to double check?

Resolves issues:

#3644 (comment)

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.5.0 milestone Aug 31, 2023
@robwalch
Copy link
Collaborator Author

cc @deepak-bomotix

@robwalch robwalch changed the title Fix support of skip directive without block reload (Regressed in #5317) Fix support of skip directive without block reload Aug 31, 2023
@robwalch robwalch force-pushed the bugfix/skip-directive-without-block-reload branch from 5c8d086 to d8682e3 Compare September 1, 2023 15:00
@robwalch robwalch mentioned this pull request Sep 1, 2023
@robwalch robwalch merged commit b96fd52 into master Sep 1, 2023
17 checks passed
@robwalch robwalch deleted the bugfix/skip-directive-without-block-reload branch September 1, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant