test(chrome) Fix chrome tests for last versions #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
You're going to kill me... You have to remove this from the commit message: If you fill the "breaking change" question that will trigger a new major release since a breaking change has been detected by semantic release. Can you remove that from both commit messages please? |
added 2 commits
January 4, 2019 10:21
…usky. Fix tests with methods starting by 'webkit' to prevent errors on the last versions of chrome.
Fix some tests using methods starting by 'webkit' for passing successfully the tests. Update to husky version.
|
Ok, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update method names of some tests in /vg-api.spec.ts to allow compatibility with last versions of chrome in tests.
Update version of husky.
Checklist
npm start)npm test)