Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please bump mux.js version to fix missing PTS/DTS crash on keyframes #503

Closed
cmacq2 opened this issue May 9, 2019 · 2 comments
Closed

Comments

@cmacq2
Copy link

cmacq2 commented May 9, 2019

Description

As of mux.js 5.1.2 a particular crash is fixed when the first keyframe of a TS segment does not contain PTS/DTS information in the PES: videojs/mux.js#250 However, videojs/http-streaming pins the mux.js dependency to 5.1.1 currently. In order to benefit from the bug fix the version should be bumped to at least 5.1.2.

Once a new version of @videojs/http-streaming is available that fixes this, the video.js project should be updated likewise to bump its pinned dependency on @videojs/http-streaming from 1.10.1 to at least the fixed version.

videojs version

@videojs/http-streaming: versions up to current (1.10.1)
video.js: versions up to current (7.5.4)

Browsers

All: this is a bug caused by missing error checking in mux.js prior to 5.1.1.

Platforms

All: this is a bug caused by missing error checking in mux.js prior to 5.1.1.

@welcome
Copy link

welcome bot commented May 9, 2019

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

cmacq2 added a commit to cmacq2/http-streaming that referenced this issue May 9, 2019
@gkatsev gkatsev closed this as completed in 57a38e9 May 9, 2019
@gkatsev
Copy link
Member

gkatsev commented May 9, 2019

Thanks for the reminder, I closed the greenkeeper PR previously because I thought it only included the license related change. The update is merged in but we're not quite ready to make a VHS release yet, there are a couple of pending PRs that we want to get in (#469, #500, #502)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants