fix: only reset syncController if we passed a discontinuity #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unless anyone gets a good idea, I don't think there's a good test to add for this. |
|
Doesn't seem to cause issues with demuxed audio stream either. |
gkatsev
force-pushed
the
no-timeline-changes-without-disco
branch
from
987ee88
to
09cb05c
Compare
mjneil
reviewed
May 13, 2019
mjneil
previously requested changes
May 13, 2019
mjneil
previously approved these changes
May 13, 2019
|
Can't come up with a better test, unfortunately. |
gkatsev
force-pushed
the
no-timeline-changes-without-disco
branch
from
773195c
to
07bc359
Compare
gesinger
pushed a commit
to gesinger/http-streaming
that referenced
this pull request
Feb 19, 2020
gkatsev
pushed a commit
that referenced
this pull request
Feb 25, 2020
* fix: only reset syncController if we passed a discontinuity (#502) * Delay timestamp offset changes for segments without audio or video data If a timeline change occurs, but the requested segment doesn't contain any audio or video data, delay the timestamp offset changes for the source buffers and transmuxer until the next segment with audio or video data. This provides a mechanism to avoid setting an improper timestamp offset for segments containing no audio or video data, as audio or video timing information is required to provide a correct timestamp offset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.