Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changeType on full codec change only #1474

Merged
merged 2 commits into from
Feb 3, 2024
Merged

fix: changeType on full codec change only #1474

merged 2 commits into from
Feb 3, 2024

Conversation

adrums86
Copy link
Contributor

Description

Call changeType only when the codec base has changed.

Specific Changes proposed

Parse the codec base from the new codec and the existing codec for the given track and compare that to determine if we need to call changeType on the source buffer.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ceb780a) 86.06% compared to head (af2d2e4) 86.06%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1474   +/-   ##
=======================================
  Coverage   86.06%   86.06%           
=======================================
  Files          42       42           
  Lines       10749    10752    +3     
  Branches     2474     2474           
=======================================
+ Hits         9251     9254    +3     
  Misses       1498     1498           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrums86 adrums86 marked this pull request as ready for review January 22, 2024 17:30
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me!

@adrums86 adrums86 merged commit 4e51778 into main Feb 3, 2024
15 checks passed
@adrums86 adrums86 deleted the fix-changeType branch February 3, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants