708 caption signaling #132
Conversation
src/inheritAttributes.js
Outdated
|
|
||
| return values.map((value) => { | ||
| // service or channel number 1-63 | ||
| let channel; |
There was a problem hiding this comment.
Should these all reside within a flags object?
There was a problem hiding this comment.
yeah, might make it a bit easier, then we can just return the flags object below
src/inheritAttributes.js
Outdated
| // BIT 1/0 | ||
| // If 3d metadata is present (CEA-708.1) then 1 | ||
| // default 0 | ||
| let threed = 0; |
There was a problem hiding this comment.
If we do go with a flags object we could make this 3d as threed just looks like a mis-spelling to me.
| svcObj[language] = { | ||
| autoselect: false, | ||
| default: false, | ||
| instreamId: channel, | ||
| language | ||
| }; | ||
|
|
||
| if (service.hasOwnProperty('aspectRatio')) { |
There was a problem hiding this comment.
Is there any reason not to add all properties?
There was a problem hiding this comment.
If we add them when not present, the output of both 608 and 708 will include things like aspectRatio, where we want them only for 708.
There was a problem hiding this comment.
Well I meant add any properties that service has.
There was a problem hiding this comment.
the three extra props that it has are copied over. Channel and language are already accounted for above.
This is 708 caption signaling.
One limitation I found as part of this is that if multiple services are of the same language, they can't be represented in mediaGroups as they're defined right now. For example, the following 708 signal
1=lang:eng;2=lang:eng,war:1,er:1will only surface the SERVICE2 item since both get added under media groups undereng.