feat: node support #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
Aug 28, 2019
| @@ -1,7 +1,9 @@ | |||
| import window from 'global/window'; | |||
|
|
|||
| const atob = (s) => window.atob ? window.atob(s) : Buffer.from(s, 'base64').toString('binary'); | |||
There was a problem hiding this comment.
node does not have window.atob
brandonocasey
commented
Aug 28, 2019
| @@ -9,7 +9,7 @@ const resolveUrl = (baseUrl, relativeUrl) => { | |||
|
|
|||
| // if the base URL is relative then combine with the current location | |||
| if (!(/\/\//i).test(baseUrl)) { | |||
| baseUrl = URLToolkit.buildAbsoluteURL(window.location.href, baseUrl); | |||
| baseUrl = URLToolkit.buildAbsoluteURL(window.location && window.location.href || '', baseUrl); | |||
There was a problem hiding this comment.
node does not have a location.
brandonocasey
force-pushed
the
feat/node-support
branch
from
91bb7b2
to
315ab8d
Compare
brandonocasey
commented
Aug 28, 2019
| const currentLocation = window.location.protocol + '//' + window.location.host; | ||
| let currentLocation = ''; | ||
|
|
||
| if (window.location && window.location.protocol) { |
There was a problem hiding this comment.
node does not have a location.
brandonocasey
changed the title
This was referenced Aug 28, 2019
misteroneill
approved these changes
Aug 30, 2019
gkatsev
approved these changes
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See code comments.