Skip to content

Commit

Permalink
fix(player): reset CSS classes at player.reset (#8487)
Browse files Browse the repository at this point in the history
Allows CSS classes to be reset when `player.reset` is called,
so that the player is close to its initial state.

- remove `vjs-playing`
- add `vjs-paused`
  • Loading branch information
amtins committed Dec 4, 2023
1 parent 5f4aa91 commit 849098f
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/js/player.js
Original file line number Diff line number Diff line change
Expand Up @@ -3599,6 +3599,10 @@ class Player extends Component {
if (this.tech_) {
this.tech_.clearTracks('text');
}

this.removeClass('vjs-playing');
this.addClass('vjs-paused');

this.resetCache_();
this.poster('');
this.loadTech_(this.options_.techOrder[0], null);
Expand Down
4 changes: 4 additions & 0 deletions test/unit/player.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1911,6 +1911,8 @@ QUnit.test('player#reset loads the Html5 tech and then techCalls reset', functio
techOrder: ['html5', 'youtube']
},
error() {},
addClass() {},
removeClass() {},
resetCache_() {},
loadTech_(tech, source) {
loadedTech = tech;
Expand Down Expand Up @@ -1944,6 +1946,8 @@ QUnit.test('player#reset loads the first item in the techOrder and then techCall
techOrder: ['youtube', 'html5']
},
error() {},
addClass() {},
removeClass() {},
resetCache_() {},
loadTech_(tech, source) {
loadedTech = tech;
Expand Down

0 comments on commit 849098f

Please sign in to comment.