fix(player): reset CSS classes at player.reset #8487
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8487 +/- ##
==========================================
- Coverage 82.71% 82.71% -0.01%
==========================================
Files 113 113
Lines 7592 7591 -1
Branches 1826 1826
==========================================
- Hits 6280 6279 -1
Misses 1312 1312 ☔ View full report in Codecov by Sentry. |
src/js/player.js
Outdated
| @@ -3599,6 +3599,11 @@ class Player extends Component { | |||
| if (this.tech_) { | |||
| this.tech_.clearTracks('text'); | |||
| } | |||
|
|
|||
| this.removeClass('vjs-playing'); | |||
| this.removeClass('vjs-has-started'); | |||
There was a problem hiding this comment.
the others make sense but I don't think we want to remove this one. Yes, the player is reset, but it should still be in started state, could be a breaking change, potentially as well.
There was a problem hiding this comment.
@gkatsev thank you for taking the time to review this PR and for the feedback. I removed this.removeClass('vjs-has-started');
amtins
force-pushed
the
fix/player-el-reset-classlist
branch
from
fb83d87
to
c1e4790
Compare
Allows CSS classes to be reset when `player.reset` is called, so that the player is close to its initial state. - remove `vjs-playing` - add `vjs-paused`
amtins
force-pushed
the
fix/player-el-reset-classlist
branch
from
c1e4790
to
da12821
Compare
Description
Allows CSS classes to be reset when
player.resetis called, so that the player is close to its initial state.Specific Changes proposed
vjs-playingvjs-pausedRequirements Checklist