NVDA Windows Chrome & Firefox - Play button is repeated multiple times when clicked. #5023
Comments
|
This issue still occur when focus is not on play button |
|
The interesting thing is what is announced is "Play Play lay Play Play Play" |
|
http://jsbin.com/piqulisose/2/edit?html,js,console |
|
I found a workaround by removing title attribute of original play control button . <button class="vjs-play-control vjs-control vjs-button" type="button" aria-live="polite" title="Play" aria-disabled="false">
<span aria-hidden="true" class="vjs-icon-placeholder">
</span>
<span class="vjs-control-text">Play</span>
</button>If we remove inner span will reduce 2 times in Chrome. |
|
Hey, thanks for the issue. We knew this has been happening but haven't had a chance to take a look at it. The title attribute was originally added so that you can visually read what a button that only had an icon but this is clearly causing issues. The plan is to go with removing the title attribute and add our own tooltip. |
|
This is reproducible without Video.js as well: http://solutions.brightcove.com/abarstow/BC-39639/nvda-test.html |
… a button when its text label changes. Partial fix to videojs#5023
…me of a button when its text label changes. (#5158) Move the aria-live attribute to the control text element within buttons, rather than on the whole button, so it is not affected by the change of the title attribute, only by the change of the control text. It seems like having aria-live on the button itself means that JAWS and NVDA announce the button both when the button text changes and when the title attribute changes. NVDA speaks the new label more times because it announces the button text as the label and the title as the description, so it says, for example, "pause button pause". JAWS doesn't appear to do this, so it doesn't repeat it as many times. Partially addresses #5023
…me of a button when its text label changes. (#5158) Move the aria-live attribute to the control text element within buttons, rather than on the whole button, so it is not affected by the change of the title attribute, only by the change of the control text. It seems like having aria-live on the button itself means that JAWS and NVDA announce the button both when the button text changes and when the title attribute changes. NVDA speaks the new label more times because it announces the button text as the label and the title as the description, so it says, for example, "pause button pause". JAWS doesn't appear to do this, so it doesn't repeat it as many times. Partially addresses #5023
|
This should be fixed as part of #5158 |
Description
Once NVDA focus is on the play button and the button is clicked, NVDA repeats the state of the button multiple times (Chrome 6 times, Firefox 3 times).
Steps to reproduce
With NVDA running, go to videojs.com and click the play button, either through enter key or mouse click.
Results
Expected
The state of the play button is stated only once when clicked.
Actual
The state of the play button is stated 6 times in Windows Chrome and 3 times in Windows Firefox when clicked. e.g. When the play button is clicked in Windows Chrome, NVDA will read "Play, Play, Play, Play, Play, Play".
Error output
N/A
Additional Information
versions
videojs
Latest version on video.js website.
browsers
Chrome, Firefox
OSes
Windows 7 & 10
plugins
The text was updated successfully, but these errors were encountered: