Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError when using vtt with span using version 6.2.5 #5138

Closed
morangil opened this issue May 2, 2018 · 4 comments
Closed

TypeError when using vtt with span using version 6.2.5 #5138

morangil opened this issue May 2, 2018 · 4 comments

Comments

@morangil
Copy link

morangil commented May 2, 2018

Description

I set my tracks to nativeAudioTracks: false and nativeTextTracks: false and console is throng an error when there's is a span on my vtt file (such as <i><b>.. )

Error output

VIDEOJS: ERROR: TypeError: Cannot assign to read only property 'localName' of object '#<HTMLElement>'

@gkatsev
Copy link
Member

gkatsev commented May 4, 2018

This happens when vttjs runs in strict mode. We can probably remove localName from vttjs, but I haven't had a change to make this change and test it.
As a workaround for now, try disabling running video.js/vtt.js in strict mode.

@stale
Copy link

stale bot commented Aug 10, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated Things closed automatically by stalebot label Aug 10, 2018
@gkatsev gkatsev added confirmed and removed outdated Things closed automatically by stalebot labels Aug 10, 2018
@vermie
Copy link

vermie commented Jul 9, 2021

Is this resolved by videojs/vtt.js#40?

@gkatsev
Copy link
Member

gkatsev commented Jul 9, 2021

Yes, it does! Looks like it's been in Video.js since 7.7.2: https://github.com/videojs/video.js/blob/main/CHANGELOG.md#772-2019-12-02
Good catch @vermie!

@gkatsev gkatsev closed this as completed Jul 9, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants