Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removes localName assignment. #40

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

gjanblaszczyk
Copy link
Member

This PR is related to #15 and removes the localName (read-only) assignment.

@gjanblaszczyk
Copy link
Member Author

I have created this PR because I have a problem with subtitles when I import video.js as an ES module in the browser. I see a similar PR on the official repo (mozilla/vtt.js#371) but it is still not merged. I wonder if we could merge the PR inside video.js fork to fix a problem. @gkatsev, any thoughts?

@gkatsev
Copy link
Member

gkatsev commented Aug 29, 2019

Thanks for pinging again, totally forgot about it. Unfortunately, mozilla/vtt.js is basically unmaintained right now
In Video.js for various reasons, we had just disabled "use strict" for our bundler, but that may not necessarily work in other bundlers.
I think this is probably reasonably, I don't imagine it'll cause many issues.

@gjanblaszczyk
Copy link
Member Author

Yes, I think the same, I have done some tests for this PR and I haven't found any problems... It would be great to see it merged.

@gkatsev
Copy link
Member

gkatsev commented Nov 25, 2019

This may allow us to remove a change we did in Video.js to ask rollup not to add "use strict" to the top of modules.

@gkatsev gkatsev merged commit 8e66a83 into videojs:master Nov 25, 2019
@gjanblaszczyk
Copy link
Member Author

Yeah, This is a great idea.

gkatsev added a commit to videojs/video.js that referenced this pull request Dec 2, 2019
We had to turn off strict mode (#4551) in Video.js due to a change in vtt.js. That has now been fixed in videojs/vtt.js#40 and released as part of 0.15.2 which will be available via #6333.

Fixes videojs/vtt.js#15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants