-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VideoJS component for Bower #536
Comments
There's a few issues with committing the compiled code.
I attempted to create an alternative repo, and registered with that. Does it work for you?
|
An alternative repo is perfect. It just needs a semver tag to work. Could you tag it "4.0.1"? |
Tags pushed. Let me know if that works. On May 23, 2013, at 7:55 PM, lukebussey notifications@github.com wrote:
|
Works great! I'll request the other repo removed from the bower component repository. |
There's another one? On May 30, 2013, at 2:18 PM, lukebussey notifications@github.com wrote:
|
There is
|
It'd be great to delete that one, but there's still no way to delete stuff from bower, yeah? |
You can request to get it deleted but yeah, basically you can't get rid of anything. |
FYI, we're going to be moving back to using the main repo for bower, once we get #874 pulled in. |
@heff What's the status of this?
|
And the dist files are removed from main repo efe25c0, how to install via bower now? |
|
I think |
Any luck updating bower to point to the correct component? As is, we're having to reference the full git path, as bower only points to the component repo for both Thanks |
I believe it should be updated. Can you try and let us know if its still not the case? |
Figured it out. Its a problem of video.js version 4.3 apparently it doesn't ship with a /dist folder, just the raw components. |
for the time being, i guess we'll need to stick with git full path |
@uxtx, is the problem that you can't upgrade the video.js version? I just bower installed both videojs and video.js and both point to the right repo. Also, hi Dave. :) |
Hi @heff, thanks for sharing some clue here. That's correct, it's a problem with this version. We're planning on upgrading in the roadmap, but needed to do some regression testing first... i guess maybe we need to move up the timeline ;) . Anyhow, ya I think the issue is specific to the version I'm targeting. I've attached my bower.json for reference. When i install with this version targeted, no
Thanks again, and hope all is well for you and yours! |
Totally makes sense for older versions to not have a |
that makes sense. I'll just point to the videojs-components git repo then for the short term, until we're ready to upgrade. Thanks again guys. |
I'm requesting that video.js be made into a Bower component so that it can simply be installed using the command
bower install -save videojs
. Currently it can be installed but can't be used without first building, which is an extra step in the workflow.All it would take is to add the following code into a bower.json file and committing the dist directory.
Any chance of this happening?
Thanks,
Luke
The text was updated successfully, but these errors were encountered: