Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a version task #874

Closed
wants to merge 3 commits into from
Closed

Conversation

dmlap
Copy link
Member

@dmlap dmlap commented Dec 4, 2013

Add a new grunt task to create a new release version. It can be run like this:

grunt dist version:patch

Running dist before the version task is required so the build artifacts are available. The task uses npm version to bump the package version, copies the new version into the bower file and then force commits the dist directory in one shot. If that's successful, the dist directory is deleted in another commit so that no one accidentally makes patches against those files.

With the bower.json file now directly in the repo, I think it should be possible to retire video.js-component

Add a new grunt task to create a new release version. It can be run like this:

grunt dist version:patch

Running dist before the version task is required so the build artifacts are available. The task uses `npm version` to bump the package version, copies the new version into the bower file and then force commits the dist directory in one shot. If that's successful, the dist directory is deleted in another commit so that no one accidentally makes patches against those files.
@gkatsev
Copy link
Member

gkatsev commented Dec 4, 2013

Might as well add a grunt publish or something which does an npm publish as well as a git push --tags (aka, bower publish).

@dmlap
Copy link
Member Author

dmlap commented Dec 4, 2013

Well, the nice thing about this version is it only messes with your local repo so you get the choice of how you want to publish it. I'd like to be able to make patched versions of video.js occasionally for testing but I don't necessarily want to push it out to my fork.

@gkatsev
Copy link
Member

gkatsev commented Dec 4, 2013

Yep, the publish should be another task.

@heff
Copy link
Member

heff commented Dec 4, 2013

Very cool. Could this possibly be broken up into even smaller tasks. I'm already using other versioning processes in contribflow that include things like changelog updates as well, and I'll need to figure out how to work them together.
https://github.com/zencoder/contribflow/blob/master/lib/hotfix.js

Create three smaller release tasks: check-for-changes, version, and commit-version. Add a roll-up task to execute them in the proper order. To create a minor release, you would run:

grunt release --type=minor
If no npmignore is present, npm will fall back on the gitignore. Our gitignore ignores dist/, which is the exact opposite of what we want npm to do. Adding an explicit npmignore overrides the settings for git. This one is based on the gitignore, with dist/ removed and some entries which appeared to be for older layouts of the repo.
@heff
Copy link
Member

heff commented Feb 7, 2014

Going to use the version of this that's going into the swf.

@heff heff closed this Feb 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants