chore: package json cleanup #5649

brandonocasey · 2018-12-04T19:31:47Z

Remove packages that we really don't need:

bluebird - use native promises instead
klawsync - use shelljs
babel/* - lots of unused/uneeded babel packages, especially after converting from import to require for our build scripts
minimist - Was only used in one place, and we can just manually look for the one argument.
tsml no longer maintained

Turns on linting for almost everything
Uses lint-staged to update the translations-needed doc
Uses lint-staged to lint and fix docs

brandonocasey · 2018-12-04T19:33:12Z

package.json

    "build:lang": "npm-run-all build:lang:*",
    "build:lang:js": "vjslang --dir dist/lang",
    "build:lang:copy": "shx cp -R lang/* dist/lang/",
    "minify": "npm-run-all minify:*",
-    "minify:js": "babel-node build/minify.js",


After the rollup tests pr is merged, I will work on a pr to use the shared rollup config, then the minify script will go away entirely.

Having rollup minify significantly increased build times because it had to be a separate rollup build.

now that terser supports include/exclude this won't be an issue.

gkatsev · 2018-12-05T21:59:37Z

build/assets.js

-.then(mapFiles)
-.then(function(files) {
-  logTable(files);
+const filepaths = sh.find(path.join(__dirname, '..', 'dist', '**', '*.{js,css}')).filter(function(filepath) {


I think using klawSync is a lot more readable than using sh.find

So for me klawSync wasn't actually working here. I did not see an ignore option anymore. Now it seems you have to filter on your own. So klawSync would be mostly the same. The path.join is just so we can run this script from any directory and not just the root of the project.

gkatsev · 2018-12-05T22:00:41Z

build/assets.js

  });
-}
-
-function logTable(files) {


keeping these as named functions rather than inlining them into the promise chain increases readability of this file and the promise chain.

For me it seemed like this file was very hard to follow with named functions and lot of the function arguments had weird argument names relative to what they actually were. I went back and looked at the file and found a few places to simplify it further and added comments.

gkatsev · 2018-12-05T22:03:35Z

build/sandbox.js


-const files = klawSync('sandbox/').filter((file) => path.extname(file.path) === '.example');
+const files = sh.find(path.join(__dirname, '..', 'sandbox', '**', '*.*'))


klawSync is more readable, I think

gkatsev · 2018-12-05T22:03:59Z

build/sandbox.js

-.filter(function(change) {
-  return !fs.existsSync(change.copy);
-});
+  .filter(function(change) {


does the linter fix this?

I think that it did

gkatsev · 2018-12-05T22:04:12Z

build/generate-example.js

@@ -42,11 +41,20 @@ export default function generateExample({skipBuild} = {}) {
    sh.cp(path.join(vjsSwf, 'dist', 'video-js.swf'), swfDest);
  }

-  const files = klawSync('sandbox/').filter((file) => path.extname(file.path) === '.example');
+  const filepaths = sh.find(path.join(__dirname, '..', 'sandbox', '**', '*.*'))


klawSync is more readable, I think

We could use just sandbox/ for find too, but then the scripts don't work if run from somewhere other than the root dir

brandonocasey · 2018-12-05T22:15:50Z

General comment about klawSync I think it's doing more than we need in all but one script, ie find and stat when we just need find. I think removing the dependency is worth it in this case.

stale · 2019-03-09T18:33:56Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

brandonocasey · 2019-07-17T17:32:33Z

package.json

+      "remark --output --",
+      "git add"
+    ],
+    "lang/*.json": [


automatic translation updates on commit when they are changed!

brandonocasey · 2019-08-29T18:09:24Z

build/version.js

@@ -1,19 +0,0 @@
-var safeParse = require("safe-json-parse/tuple");


This file was removed in favor of doing what we do in the generator with not-prelease

gkatsev · 2019-08-30T17:23:38Z

build/assets.js

+// find all js/css files in the dist dir
+// but ignore any files in lang, example, or font directories
+const filepaths = sh.find(path.join(__dirname, '..', 'dist', '**', '*.{js,css}')).filter(function(filepath) {
+  if ((/\/(lang|example|font)\//).test(filepath)) {


you could just return !(/.../.test(filepath);

gkatsev · 2019-08-30T17:30:27Z

build/generate-example.js

-}
+};
+
+generateExample({skipBuild: true});


I don't think we need to run this on require.

gkatsev · 2019-08-30T17:38:02Z

package.json

@@ -18,6 +18,7 @@
  "author": "Steve Heffernan",
  "scripts": {
    "sandbox": "node build/sandbox.js",
+    "assert": "node build/assets.js",


This already exists as assets script.

gkatsev · 2019-08-30T17:42:51Z

package.json

    "prepublishOnly": "run-p build",
    "publish": "node build/gh-release.js",
-    "version": "node build/version.js && git add CHANGELOG.md",
+    "update-changelog": "conventional-changelog -p videojs -i CHANGELOG.md -s",


we already have the changelog script.

brandonocasey commented Dec 4, 2018

View reviewed changes

brandonocasey force-pushed the chore/package-json-cleanup branch 3 times, most recently from 83025fc to b9ad98e Compare December 5, 2018 21:35

gkatsev reviewed Dec 5, 2018

View reviewed changes

gkatsev added patch This PR can be added to a patch release. chore labels Dec 10, 2018

brandonocasey force-pushed the chore/package-json-cleanup branch 2 times, most recently from f435e2a to 1d7e7ce Compare December 12, 2018 16:06

brandonocasey force-pushed the chore/package-json-cleanup branch 2 times, most recently from 6f01bfd to 89fae82 Compare January 8, 2019 17:37

brandonocasey mentioned this pull request Jan 14, 2019

Fix package deprecation warnings videojs/generator-videojs-plugin#272

Open

8 tasks

stale bot added the outdated Things closed automatically by stalebot label Mar 9, 2019

gkatsev removed the outdated Things closed automatically by stalebot label Mar 12, 2019

brandonocasey mentioned this pull request Mar 12, 2019

feat: add several debugging aides #5854

Closed

brandonocasey force-pushed the chore/package-json-cleanup branch 4 times, most recently from ed52a8f to 7675c35 Compare March 20, 2019 15:30

brandonocasey force-pushed the chore/package-json-cleanup branch from 7675c35 to 33ada18 Compare March 22, 2019 15:10

brandonocasey force-pushed the chore/package-json-cleanup branch from 33ada18 to 7350c96 Compare April 25, 2019 18:51

brandonocasey force-pushed the chore/package-json-cleanup branch from 7350c96 to 06c552c Compare May 9, 2019 20:04

brandonocasey force-pushed the chore/package-json-cleanup branch from 06c552c to de93caf Compare June 27, 2019 20:46

brandonocasey force-pushed the chore/package-json-cleanup branch 2 times, most recently from a260e20 to b21d893 Compare July 17, 2019 17:31

brandonocasey commented Jul 17, 2019

View reviewed changes

brandonocasey closed this Jul 18, 2019

brandonocasey deleted the chore/package-json-cleanup branch July 18, 2019 19:12

brandonocasey restored the chore/package-json-cleanup branch July 18, 2019 19:12

brandonocasey reopened this Jul 18, 2019

brandonocasey force-pushed the chore/package-json-cleanup branch from b21d893 to 88d7c9c Compare July 18, 2019 19:17

brandonocasey force-pushed the chore/package-json-cleanup branch from 88d7c9c to 967360d Compare August 29, 2019 18:03

brandonocasey commented Aug 29, 2019

View reviewed changes

brandonocasey force-pushed the chore/package-json-cleanup branch 2 times, most recently from 3b0b4dc to d9e7a6d Compare August 29, 2019 21:50

brandonocasey added 2 commits August 30, 2019 13:19

chore: package json cleanup

09a32f8

fix language bug

554bc3e

brandonocasey force-pushed the chore/package-json-cleanup branch from d9e7a6d to 554bc3e Compare August 30, 2019 17:19

gkatsev reviewed Aug 30, 2019

View reviewed changes

cr

d08fbef

gkatsev approved these changes Aug 30, 2019

View reviewed changes

gkatsev merged commit 85ad44e into master Aug 30, 2019

gkatsev deleted the chore/package-json-cleanup branch August 30, 2019 18:14

This was referenced Mar 19, 2020

[Snyk] Upgrade video.js from 7.4.1 to 7.7.5 videojs/videojs-playlist#173

Closed

[Snyk] Upgrade video.js from 7.6.6 to 7.7.5 videojs/videojs-errors#192

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: package json cleanup #5649

chore: package json cleanup #5649

brandonocasey commented Dec 4, 2018

brandonocasey Dec 4, 2018

gkatsev Dec 5, 2018

brandonocasey Jul 17, 2019

gkatsev Dec 5, 2018

brandonocasey Dec 5, 2018

gkatsev Dec 5, 2018

brandonocasey Dec 5, 2018

gkatsev Dec 5, 2018

gkatsev Dec 5, 2018

brandonocasey Dec 5, 2018

gkatsev Dec 5, 2018

brandonocasey Dec 5, 2018

brandonocasey commented Dec 5, 2018

stale bot commented Mar 9, 2019

brandonocasey Jul 17, 2019

brandonocasey Aug 29, 2019

gkatsev Aug 30, 2019

gkatsev Aug 30, 2019

gkatsev Aug 30, 2019

gkatsev Aug 30, 2019


		const files = klawSync('sandbox/').filter((file) => path.extname(file.path) === '.example');
		const files = sh.find(path.join(__dirname, '..', 'sandbox', '*', '.*'))

		@@ -1,19 +0,0 @@
		var safeParse = require("safe-json-parse/tuple");

chore: package json cleanup #5649

chore: package json cleanup #5649

Conversation

brandonocasey commented Dec 4, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brandonocasey commented Dec 5, 2018

stale bot commented Mar 9, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment