Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is options function deprecated? #6048

Closed
cristian-atehortua opened this issue Jun 12, 2019 · 2 comments · Fixed by #6056
Closed

Why is options function deprecated? #6048

cristian-atehortua opened this issue Jun 12, 2019 · 2 comments · Fixed by #6056

Comments

@cristian-atehortua
Copy link

This is a question: Why is options function deprecated? I mean, is there a way to set options after a component is constructed? Is there a way to get options later without using "private" property options_?

@welcome
Copy link

welcome bot commented Jun 12, 2019

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@gkatsev
Copy link
Member

gkatsev commented Jun 17, 2019

The thought at the time was that option() shouldn't be publicly available and that individual plugins and components should expose the specific items that can and should be changed via an API. However, it seems like there's a lot of usage of options() and removing it is likely to cause a lot of churn, so, we may end up never removing it.

gkatsev added a commit that referenced this issue Jun 17, 2019
gkatsev added a commit that referenced this issue Jun 18, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants