Restore timeupdate/loadedmetadata listeners for duration display #3682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
added
patch
|
LGTM. I'll get it merged some time tomorrow. Also, would be easier if you allow me to make changes to the PR (checkbox on the sidebar, I think). |
misteroneill
added
confirmed
and removed
needs: LGTM
|
@gkatsev The "Allow edits from maintainers" checkbox is checked. 😕 |
|
Ah, maybe there just isn't an indicator to let me know whether it's available or not. |
|
This is released as part of 5.11.8. |
|
It's in master 44ec0e4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a possible source of breakage introduced in #3349 where dependent applications could be using the removed events to manually force a duration display update.
Requirements Checklist