feat(texttracks): always use emulated text tracks #3798
Conversation
|
😖 LGTM |
| } | ||
|
|
||
| return supportsTextTracks; | ||
| return browser.IS_ANY_SAFARI; |
There was a problem hiding this comment.
wasn't the issue only with chrome? should we still support native on firefox?
There was a problem hiding this comment.
We don't currently support native tracks on Firefox anyway. Firefox 50 may be better but older versions definitely had issues.
Also, I think it would be better to be consistent as much as we can.
There was a problem hiding this comment.
ok maybe we should just have an issue/TODO comment to revisit this at another time?
There was a problem hiding this comment.
Well, now is the time. Either we should strive to always try and use native tracks or we should try and always use emulated tracks. Safari is a bit of a special case, particularly because of iOS and HLS that we allow native tracks for it.
There was a problem hiding this comment.
I am all for always using emulated tracks, because we can control all of the behavior
There was a problem hiding this comment.
I agree with a move to doing emulated tracks wherever possible; I've been meaning to file an issue because, in order to support Descriptions tracks, you have to use emulated tracks even if the browser claims it supports text tracks, and having to switch to emulated tracks just because you want to add support for Descriptions tracks isn't going to be popular, if sites have become used to native track styles and controls. Emulated tracks allow the kind of cross-browser consistency, similar to control bar consistency, that is one of video.js' greatest strengths.
Chrome has a bug where if you add a remote text track and try to use it programmatically, you won't get any cues displayed. So, just switch to always emulated mode. Also, add IS_SAFARI and IS_ANY_SAFARI to the browsers. Conflicts: src/js/tech/html5.js test/unit/tracks/text-tracks.test.js
Chrome has a bug where if you add a remote text track and try to use it programmatically, you won't get any cues displayed. So, just switch to always emulated mode.
Also, add
IS_SAFARIandIS_ANY_SAFARIto the browsers.