Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove grunt move to npm scripts #5592

Merged
merged 15 commits into from Nov 30, 2018
Merged

chore: Remove grunt move to npm scripts #5592

merged 15 commits into from Nov 30, 2018

Conversation

brandonocasey
Copy link
Contributor

@brandonocasey brandonocasey commented Nov 14, 2018 •
edited by gkatsev

Depends on #5589

Remove grunt altogether for npm scripts.

@gkatsev
Copy link
Member

gkatsev commented Nov 15, 2018

https://github.com/videojs/video.js/blob/master/Gruntfile.js can be removed as well

@gkatsev
Copy link
Member

gkatsev commented Nov 15, 2018

We need to comb through out docs and remove grunt and update to npm commands

@brandonocasey brandonocasey changed the base branch from chore/lang-a11y to master November 16, 2018 17:15
gkatsev
gkatsev reviewed Nov 16, 2018
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the karma-config update didn't get rebased properly

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
gkatsev
gkatsev reviewed Nov 16, 2018
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, overall, npm start, npm test, and npm run build work.

package.json Outdated Show resolved Hide resolved
package.json Outdated
"postclean": "shx mkdir -p ./dist/lang ./test/dist",
"changelog": "conventional-changelog -p videojs -i CHANGELOG.md -s",
"build": "npm-run-all build-dev minify zip",
"build-dev": "npm-run-all clean lint-errors build:js build:css build:lang build:copy build:test",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move build:test just to npm test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While that kind of makes sense, I think these should be bulit here so that they exist for the dev server.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
gkatsev
gkatsev reviewed Nov 16, 2018
View reviewed changes
package.json Outdated Show resolved Hide resolved
gkatsev
gkatsev reviewed Nov 16, 2018
View reviewed changes
package.json Outdated
"postclean": "shx mkdir -p ./dist/lang ./test/dist",
"changelog": "conventional-changelog -p videojs -i CHANGELOG.md -s",
"build": "npm-run-all build-dev minify zip",
"build-dev": "npm-run-all clean lint-errors build:js build:css build:lang build:copy build:test",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build:copy only needs to run on publish, there's nothing in there that's used for dev

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's fine to leave it to match current functionality

package.json Outdated Show resolved Hide resolved
@gkatsev
Copy link
Member

gkatsev commented Nov 16, 2018

Also, I realized that there are grunt tasks that were being used but not currently set:

  • cdn-links - used to fix up some URLs in the generated API docs
  • languages - used to update the translations-needed doc
  • sandbox - used to set up the initial sandbox folder and keep it maintained by copying the example files over to regular html files

@gkatsev
Copy link
Member

gkatsev commented Nov 16, 2018

also, build/bin folder can be removed

@brandonocasey brandonocasey mentioned this pull request Nov 30, 2018
Closed
@gkatsev
Copy link
Member

gkatsev commented Nov 30, 2018

Last grunt tasks are ported via this PR #5634

@gkatsev
port over remaining grunt tasks, disable rollup progress on travis (#…
6b26202 
…5634)

* cr

* remove bin, migrate cdn-links

* add back sandbox as script

* sandbox script

* port over check-translations

* remove cdn-links

* remove no longer used grunt tasks

* update npm-run-all

* progress from regular rollup build

* regenerator package-lock

* no progress on travis
@gkatsev gkatsev merged commit d72786f into master Nov 30, 2018
@gkatsev gkatsev deleted the chore/bye-grunt branch November 30, 2018 21:37
@gkatsev gkatsev mentioned this pull request Dec 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brandonocasey @gkatsev