New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove grunt move to npm scripts #5592

Merged
merged 15 commits into from Nov 30, 2018

Conversation

Projects
None yet
2 participants
@BrandonOCasey
Copy link
Contributor

BrandonOCasey commented Nov 14, 2018

Depends on #5589

Remove grunt altogether for npm scripts.

@gkatsev

This comment has been minimized.

Copy link
Member

gkatsev commented Nov 15, 2018

@gkatsev

This comment has been minimized.

Copy link
Member

gkatsev commented Nov 15, 2018

We need to comb through out docs and remove grunt and update to npm commands

@BrandonOCasey BrandonOCasey force-pushed the chore/lang-a11y branch from d722654 to 119ee74 Nov 15, 2018

@BrandonOCasey BrandonOCasey force-pushed the chore/bye-grunt branch from 2cee6b5 to f22d344 Nov 15, 2018

@BrandonOCasey BrandonOCasey force-pushed the chore/lang-a11y branch from 57365dc to 351f39f Nov 16, 2018

@BrandonOCasey BrandonOCasey force-pushed the chore/bye-grunt branch from 5dc3daf to 4c7fe03 Nov 16, 2018

@BrandonOCasey BrandonOCasey changed the base branch from chore/lang-a11y to master Nov 16, 2018

@BrandonOCasey BrandonOCasey force-pushed the chore/bye-grunt branch from 6235fd6 to 3be4c7b Nov 16, 2018

@gkatsev
Copy link
Member

gkatsev left a comment

I think the karma-config update didn't get rebased properly

Show resolved Hide resolved package.json Outdated
Show resolved Hide resolved package.json Outdated
@gkatsev
Copy link
Member

gkatsev left a comment

So, overall, npm start, npm test, and npm run build work.

Show resolved Hide resolved package.json Outdated
"postclean": "shx mkdir -p ./dist/lang ./test/dist",
"changelog": "conventional-changelog -p videojs -i CHANGELOG.md -s",
"build": "npm-run-all build-dev minify zip",
"build-dev": "npm-run-all clean lint-errors build:js build:css build:lang build:copy build:test",

This comment has been minimized.

@gkatsev

gkatsev Nov 16, 2018

Member

I would move build:test just to npm test

This comment has been minimized.

@BrandonOCasey

BrandonOCasey Nov 16, 2018

Author Contributor

While that kind of makes sense, I think these should be bulit here so that they exist for the dev server.

Show resolved Hide resolved package.json Outdated
Show resolved Hide resolved package.json Outdated
Show resolved Hide resolved package.json Outdated
Show resolved Hide resolved package.json Outdated
"postclean": "shx mkdir -p ./dist/lang ./test/dist",
"changelog": "conventional-changelog -p videojs -i CHANGELOG.md -s",
"build": "npm-run-all build-dev minify zip",
"build-dev": "npm-run-all clean lint-errors build:js build:css build:lang build:copy build:test",

This comment has been minimized.

@gkatsev

gkatsev Nov 16, 2018

Member

build:copy only needs to run on publish, there's nothing in there that's used for dev

This comment has been minimized.

@gkatsev

gkatsev Nov 16, 2018

Member

maybe it's fine to leave it to match current functionality

Show resolved Hide resolved package.json Outdated
@gkatsev

This comment has been minimized.

Copy link
Member

gkatsev commented Nov 16, 2018

Also, I realized that there are grunt tasks that were being used but not currently set:

  • cdn-links - used to fix up some URLs in the generated API docs
  • languages - used to update the translations-needed doc
  • sandbox - used to set up the initial sandbox folder and keep it maintained by copying the example files over to regular html files
@gkatsev

This comment has been minimized.

Copy link
Member

gkatsev commented Nov 16, 2018

also, build/bin folder can be removed

@BrandonOCasey BrandonOCasey force-pushed the chore/bye-grunt branch from f099a3d to 2cf74f6 Nov 30, 2018

@gkatsev

This comment has been minimized.

Copy link
Member

gkatsev commented Nov 30, 2018

Last grunt tasks are ported via this PR #5634

port over remaining grunt tasks, disable rollup progress on travis (#…
…5634)

* cr

* remove bin, migrate cdn-links

* add back sandbox as script

* sandbox script

* port over check-translations

* remove cdn-links

* remove no longer used grunt tasks

* update npm-run-all

* progress from regular rollup build

* regenerator package-lock

* no progress on travis

@gkatsev gkatsev merged commit d72786f into master Nov 30, 2018

4 checks passed

continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
netlify/videojs-docs/deploy-preview Deploy preview ready!
Details

@gkatsev gkatsev deleted the chore/bye-grunt branch Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment