chore: Move a11y, lang, browserify, and webpack out of grunt #5589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
force-pushed
the
chore/lang-a11y
branch
3 times, most recently
from
6ce4cc8
to
4d9c5eb
Compare
gkatsev
approved these changes
Nov 15, 2018
| "build:lang": "npm-run-all build:lang:*", | ||
| "build:lang:js": "vjslang --dir dist/lang", | ||
| "build:lang:copy": "shx --verbose cp -R lang/* dist/lang/", | ||
| "pretest:a11y": "shx cp sandbox/descriptions.html.example sandbox/descriptions.test-a11y.html", |
There was a problem hiding this comment.
at some point in the future, this may want to check if the file already exists, this way you could run the a11y test with local changes, if we had any. Definitely nothing to do right now, though.
| @@ -17,11 +17,17 @@ | |||
| "homepage": "https://videojs.com", | |||
| "author": "Steve Heffernan", | |||
| "scripts": { | |||
There was a problem hiding this comment.
we're starting to get into fiddly territory with the amount of scripts here.
There was a problem hiding this comment.
Yeah, I think we need a pr once we are off of grunt to clean it all up.
brandonocasey
force-pushed
the
chore/lang-a11y
branch
from
d722654
to
119ee74
Compare
brandonocasey
force-pushed
the
chore/lang-a11y
branch
from
57365dc
to
351f39f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves language, a11y, browserify, and webpack tasks out of grunt.
After this pull request, I think we can have two more pull requests:
dist,test,build,watchAll)