New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move a11y, lang, browserify, and webpack out of grunt #5589

Merged
merged 4 commits into from Nov 16, 2018

Conversation

Projects
None yet
2 participants
@BrandonOCasey
Copy link
Contributor

BrandonOCasey commented Nov 14, 2018

Moves language, a11y, browserify, and webpack tasks out of grunt.

After this pull request, I think we can have two more pull requests:

  1. That removes grunt and migrates the meta tasks over (dist, test, build, watchAll)
  2. A final pull request that cleans all of the package.json scripts up, making sure it still does everything we want, but in less scripts/code.

@BrandonOCasey BrandonOCasey force-pushed the chore/lang-a11y branch 3 times, most recently from 6ce4cc8 to 4d9c5eb Nov 14, 2018

Show resolved Hide resolved package.json Outdated
"build:lang": "npm-run-all build:lang:*",
"build:lang:js": "vjslang --dir dist/lang",
"build:lang:copy": "shx --verbose cp -R lang/* dist/lang/",
"pretest:a11y": "shx cp sandbox/descriptions.html.example sandbox/descriptions.test-a11y.html",

This comment has been minimized.

@gkatsev

gkatsev Nov 15, 2018

Member

at some point in the future, this may want to check if the file already exists, this way you could run the a11y test with local changes, if we had any. Definitely nothing to do right now, though.

@@ -17,11 +17,17 @@
"homepage": "https://videojs.com",
"author": "Steve Heffernan",
"scripts": {

This comment has been minimized.

@gkatsev

gkatsev Nov 15, 2018

Member

we're starting to get into fiddly territory with the amount of scripts here.

This comment has been minimized.

@BrandonOCasey

BrandonOCasey Nov 15, 2018

Author Contributor

Yeah, I think we need a pr once we are off of grunt to clean it all up.

@BrandonOCasey BrandonOCasey force-pushed the chore/lang-a11y branch from d722654 to 119ee74 Nov 15, 2018

@BrandonOCasey BrandonOCasey force-pushed the chore/lang-a11y branch from 57365dc to 351f39f Nov 16, 2018

BrandonOCasey and others added some commits Nov 16, 2018

@gkatsev gkatsev merged commit db6e376 into master Nov 16, 2018

4 checks passed

continuous-integration/codeship Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
netlify/videojs-docs/deploy-preview Deploy preview ready!
Details

@gkatsev gkatsev deleted the chore/lang-a11y branch Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment