Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role='application' to the video element on Chrome on Windows, to work around a JAWS screen reader bug (for v6.x) #5952

Closed

Conversation

OwenEdwards
Copy link
Member

Same as #5863, for v6.x.

@OwenEdwards
Copy link
Member Author

I don't know what the Travis check is failing. @gkatsev?

@gkatsev
Copy link
Member

gkatsev commented Apr 25, 2019

The 6.x branch is woefully out of date, there's definitely some fix we made in master that never made it to this branch.

@OwenEdwards
Copy link
Member Author

@gkatsev what do we do about that? I thought we were still supporting v6.x? Specifically, I know of an organization using 6.x which has run into this issue, and is hoping for a release that will fix it so that they don't have to fix it themselves. Is our guidance for them to move to 7.x?

@gkatsev
Copy link
Member

gkatsev commented Apr 29, 2019

While the upgrade is probably the best idea, it's definitely time to update 6.x with all the features and fixes in 7.x that can/should go in. It's been on the back burner since so much other stuff have been getting in the way. We probably also want to start a sunset period for 6.x.

@gkatsev gkatsev added the 6.x label May 17, 2019
@stale
Copy link

stale bot commented Jul 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated Things closed automatically by stalebot label Jul 16, 2019
@OwenEdwards
Copy link
Member Author

Bump.

@stale stale bot removed the outdated Things closed automatically by stalebot label Jul 18, 2019
@stale
Copy link

stale bot commented Sep 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated Things closed automatically by stalebot label Sep 16, 2019
@stale stale bot removed the outdated Things closed automatically by stalebot label Sep 17, 2019
@OwenEdwards
Copy link
Member Author

Apparently this issue was no longer present with JAWS 2020 (see FreedomScientific/standards-support#78 (comment)), so any user who encounters it should either update their version of JAWS, or the site developers should update to video.js 7.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants