Fix BPB announcement and operation on Chrome with JAWS screen reader #5863
Conversation
…work around a JAWS screen reader bug
| // See https://github.com/FreedomScientific/VFO-standards-support/issues/78 | ||
| // Note that we can't detect if JAWS is being used, but this ARIA attribute | ||
| // doesn't change behavior of IE11 if JAWS is not being used | ||
| if (IE_VERSION) { | ||
| // doesn't change behavior of IE11 or Chrome if JAWS is not being used |
There was a problem hiding this comment.
should this read "if JAWS is being used" rather than "if JAWS is not being used"?
There was a problem hiding this comment.
No, the comment is correct. Adding the ARIA role attribute doesn't affect IE11 or Chrome if JAWS isn't being used, so it doesn't matter that we can't detect whether JAWS is being used or not.
| // doesn't change behavior of IE11 if JAWS is not being used | ||
| if (IE_VERSION) { | ||
| // doesn't change behavior of IE11 or Chrome if JAWS is not being used | ||
| if (IE_VERSION || (IS_CHROME && IS_WINDOWS)) { |
There was a problem hiding this comment.
Is this broken with firefox on windows with JAWS as well? If so should we just check IS_WINDOWS?
There was a problem hiding this comment.
No, Firefox on Windows is okay. Originally this was only reported as an issue in IE with JAWS, but as the result of some update to Chrome, it now appears in Chrome too.
|
Note that we'll want to back-port this change to v6.x as well. |
| * @const | ||
| * @type {Boolean} | ||
| */ | ||
| export const IS_WINDOWS = (/Windows/i).test(USER_AGENT); |
There was a problem hiding this comment.
unfortunately, this makes this a minor update
gkatsev
added
the
minor
Description
Similar to #5173, this PR adds role='application' to the video element on Chrome on Windows, to work around a JAWS screen reader bug (see FreedomScientific/standards-support#78). We only add the ARIA attribute on Chrome on Windows to avoid having any impact on Chrome on other platforms (macOS, iOS, Android, etc.)
Requirements Checklist