fix: use in-spec EME for versions of Safari which support it #142
Conversation
src/eme.js
Outdated
| if (getContentId) { | ||
| sessionData.getContentId = getContentId; | ||
| } |
There was a problem hiding this comment.
Since the initData shouldn't change, we may be better off getting the contentId early and potentially saving that to the session data instead of passing the function around and saving it.
There was a problem hiding this comment.
It does seem like maybe we should save it, but I'm not sure if I want to bother untangling it right now.
@brandonocasey did you have thoughts on this?
There was a problem hiding this comment.
I will work on it, I think it might be easy enough to do.
Co-authored-by: Garrett Singer <gesinger@gmail.com>
src/eme.js
Outdated
| @@ -463,7 +451,7 @@ export const standard5July2016 = ({ | |||
| ); | |||
|
|
|||
| getLicenseFn = promisifyGetLicense(keySystem, getLicense, eventBus); | |||
| getContentIdFn = getContentId; | |||
| contentId = getContentId ? getContentId(initData) : null; | |||
There was a problem hiding this comment.
We'll also have to do it above in addPendingSessions. It might be worth trying to do it in standardizeKeySystemOptions
There was a problem hiding this comment.
I don't think it makes sense at that point, We now do it in the just before addSession
src/fairplay.js
Outdated
| @@ -128,7 +128,7 @@ export const defaultGetCertificate = (fairplayOptions) => { | |||
| }; | |||
| }; | |||
|
|
|||
| export const defaultGetContentId = (emeOptions, initData) => { | |||
| export const defaultGetContentId = (initData) => { | |||
There was a problem hiding this comment.
Technically getContentId is an exposed API (from the README), and emeOptions should be passed in case someone passes a custom getContentId
There was a problem hiding this comment.
yeah, we can't change this method signature or it'll be a breaking change.
Closes #87