-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use in-spec EME for versions of Safari which support it #142
Changes from 1 commit
bf5ffd2
2ac9b14
526f942
aaedfc1
d30ccce
c384bed
01ab95c
8f129f9
f96f3b8
b6e95b8
dad0144
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -128,7 +128,7 @@ export const defaultGetCertificate = (fairplayOptions) => { | |
}; | ||
}; | ||
|
||
export const defaultGetContentId = (emeOptions, initData) => { | ||
export const defaultGetContentId = (initData) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Technically There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah, we can't change this method signature or it'll be a breaking change. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed |
||
return getHostnameFromUri(uint8ArrayToString(initData)); | ||
}; | ||
|
||
|
@@ -174,7 +174,7 @@ const fairplay = ({video, initData, options, eventBus}) => { | |
initData, | ||
getLicense, | ||
options, | ||
contentId: getContentId(options, initData), | ||
contentId: getContentId(initData), | ||
eventBus | ||
}); | ||
}); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll also have to do it above in
addPendingSessions
. It might be worth trying to do it instandardizeKeySystemOptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it makes sense at that point, We now do it in the just before
addSession