Fix/safari 12.1 #86
Merged
Fix/safari 12.1 #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
approved these changes
May 6, 2019
|
After looking around in the tests, I found this capabilities object which did work. Progressively removing keys, it seems that Safari requires at least I will put together a PR that prefers in-spec EME over prefixed EME. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari 12.1 introduced in-spec EME API support on macOS 10.14.4 and iOS 12.2.
This plugin does not support using fairplay with the standard EME API. However, it appears that Safari's EME API is broken;
navigator.requestMediaKeySystemAccessseems to always reject. I am currently building Safari to see if I can get at some debug logs. Unfortunately, the prebuilt binaries on webkit.org don't actually work, so I have a feeling my build won't work.To bridge the gap until Safari gets its act together, this patch uses the old prefixed API if it exists.
Closes #79, #80.