Fixes for Brightcove Player and videojs integration #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 1, 2016 10:00
Trigger the 'loadstart' event in states -1 and YT.PlayerState.ENDED to show the poster Removed extraneous play() in src (since it's called in setSrc anyway) Added cueing/loading of videos when the source is set Allow non-native controls on non-stock Android browsers and stock Android 5+ browsers
Removed loadstart trigger when video is ended Return the url as a string from currentSrc()
* Added the seeking() function to the YouTube tech * Added more missing tech functions
…e certain videojs plugins (such as IMA) conflict with this
| this.options_.autoplay = val; | ||
| }, | ||
|
|
||
| loop: function() { |
There was a problem hiding this comment.
Added a setLoop function to the tech.
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of fixes were made to the YouTube tech to allow it to be used in the Brightcove Player. Most of these fixes also fix issues which could come up using a videojs player with certain plugins. Here's a list of everything that was changed:
.gitignorefile to prevent WebStorm files from being added to gitgetComponentfunction before loading the techvjs-techclass to the tech element div. This is used in several plugins withquerySelectorto retrieve the tech element div and is needed when used in a Brightcove Player.onPlayerStateChangeby settinglaststatebefore triggering any events as some listeners use the state of the player (which is stored inlaststate)loadstartevent to the loading state (state -1)autoplay,setAutoplay,loop,seeking,seekable, andpreloadcurrentSrcYT.readyfunction instead of setting awindow. onYouTubeIframeAPIReadyfunction. TheYT.readycallback function is run once the API is ready to instantiate players and prevents timing issues where theonYouTubeIframeAPIReadyfunction could potentially be overwritten by other code.Feel free to leave any comments or ask any questions about any of the changes / fixes. I am going to be away on vacation for the next week, but should hopefully be able to get around to responding to them during that time.