Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

360videos with device motion #7

Closed
wants to merge 7 commits into from
Closed

360videos with device motion #7

wants to merge 7 commits into from

Commits on May 3, 2018

  1. Devicemotion: add devicemotion for 360 videos

    @carolanitz
    carolanitz committed May 3, 2018
    Configuration menu
    Copy the full SHA
    11b9f51 View commit details
    Browse the repository at this point in the history

  2. DeviceMotion: use quaternions and convert them ourself 

    Do not use the Euler angles provided by CoreMotion as they are not defined in the same reference frame as libvlc.

Signed-off-by: Carola Nitz <nitz.carola@googlemail.com>
    @magwyz @carolanitz
    magwyz authored and carolanitz committed May 3, 2018
    Configuration menu
    Copy the full SHA
    d3ff47b View commit details
    Browse the repository at this point in the history

  3. 360Video: moved currentMediaIs360 to playbackController 

    adjusted Bool properties from nonatomic to assign
turned interfacelock off for 360Videos
    @carolanitz
    carolanitz committed May 3, 2018
    Configuration menu
    Copy the full SHA
    ed567e1 View commit details
    Browse the repository at this point in the history

  4. DeviceMotion: make panning and devicemotion interact with each other

    @carolanitz
    carolanitz committed May 3, 2018
    Configuration menu
    Copy the full SHA
    59b5de5 View commit details
    Browse the repository at this point in the history

  5. DeviceMotion: resolved jumping & not sensitive enough panning 

    lastEuler.pitch was accidentally set twice which resulted in jumping and
removing the screenscale + adjusting the zoomfactor makes panning and zooming more responsive
    @carolanitz
    carolanitz committed May 3, 2018
    Configuration menu
    Copy the full SHA
    fc80bfe View commit details
    Browse the repository at this point in the history

Commits on May 7, 2018

  1. 360 video: adjust values when they get out of bounds

    @carolanitz
    carolanitz committed May 7, 2018
    Configuration menu
    Copy the full SHA
    1079c2c View commit details
    Browse the repository at this point in the history

Commits on May 11, 2018

  1. VLCMovieViewController: 360 videos fix rotationlock 

    on iPad with iOS 9 and higher shouldAutorotate is never called since all orientations are supported by default when
we support multitasking. This lead to no rotationlock when interfacelock was enabled or a 360 video was played.
We're now using supportedInterfaceOrientations: and lock 360 videos to portrait and for interfacelock we save the current orientation and return it.
    @carolanitz
    carolanitz committed May 11, 2018
    Configuration menu
    Copy the full SHA
    6e87a1e View commit details
    Browse the repository at this point in the history