Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create VLCMedia Tests #19

Closed
wants to merge 2 commits into from
Closed

Create VLCMedia Tests #19

wants to merge 2 commits into from

Conversation

mkchoi212
Copy link
Contributor

Commits need to be rebased once #18 is merged.

@mkchoi212 mkchoi212 force-pushed the media branch 2 times, most recently from e6820b5 to d255d39 Compare June 25, 2018 08:35
return [NSString stringWithUTF8String:ret];

return @"";
return [NSString stringWithUTF8String:ret];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will crash with ret = nil. This was not redundant line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tracked it down and seems like *ret = libvlc_media_get_codec_description(...) calls vlc_fourcc_GetDescription, which has the following return statement

return LookupCat(fourcc, &ret, cat) ? ret : "";

Doesn't this mean that vlc_fourcc_GetDescription will never return nil?

@fkuehne fkuehne self-requested a review June 26, 2018 14:17
@fkuehne
Copy link
Contributor

fkuehne commented Jun 26, 2018

After removing the commit NACKed by Caro, this is good to go for me and I like it :)

@mkchoi212
Copy link
Contributor Author

Ping 🔔

@carolanitz
Copy link
Member

merged with faf2a0d

@carolanitz carolanitz closed this Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants