Create VLCMedia Tests #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkchoi212
force-pushed
the
media
branch
2 times, most recently
from
e6820b5
to
d255d39
Compare
carolanitz
reviewed
Jun 25, 2018
Sources/VLCMedia.m
Outdated
| return [NSString stringWithUTF8String:ret]; | ||
|
|
||
| return @""; | ||
| return [NSString stringWithUTF8String:ret]; |
There was a problem hiding this comment.
this will crash with ret = nil. This was not redundant line
There was a problem hiding this comment.
I tracked it down and seems like *ret = libvlc_media_get_codec_description(...) calls vlc_fourcc_GetDescription, which has the following return statement
return LookupCat(fourcc, &ret, cat) ? ret : "";Doesn't this mean that vlc_fourcc_GetDescription will never return nil?
fkuehne
approved these changes
Jun 26, 2018
|
After removing the commit NACKed by Caro, this is good to go for me and I like it :) |
mkchoi212
force-pushed
the
media
branch
3 times, most recently
from
1286fa7
to
55921e1
Compare
|
Ping 🔔 |
|
merged with faf2a0d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits need to be rebased once #18 is merged.