Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete quoting for parameters of some CMake commands #63

Closed
elfring opened this issue Mar 1, 2014 · 8 comments
Closed

Complete quoting for parameters of some CMake commands #63

elfring opened this issue Mar 1, 2014 · 8 comments
Milestone

Comments

@elfring
Copy link

elfring commented Mar 1, 2014

Some parameters (like "${PROJECT_SOURCE_DIR}" and "${DOXYGEN_EXECUTABLE}") are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like spaces.

I would recommend to apply advices from a Wiki article.

@karlrupp karlrupp added this to the Release 1.6.0 milestone Mar 2, 2014
@karlrupp
Copy link
Collaborator

karlrupp commented Mar 2, 2014

Thanks for the hint, we will fix this for the next release.

@elfring
Copy link
Author

elfring commented Oct 21, 2014

It seems that there are a few more corrections needed in the affected build scripts.

@karlrupp
Copy link
Collaborator

Thanks for the comments, I'll integrate your suggestions.

karlrupp added a commit that referenced this issue Oct 24, 2014
CMake variables which are already a list should not be put in double quotes.
Fixes a7e491f and issue #63.
@karlrupp
Copy link
Collaborator

I went over the previous changeset and removed the double quotes from all list variables. Thanks for the input, @elfring !

@elfring
Copy link
Author

elfring commented Oct 25, 2014

I find that your wording "all list variables" has got a high potential for misunderstandings.
Would you like to improve such a detail a bit more?

@karlrupp
Copy link
Collaborator

It's too late now for updating the wording, as I would have to force-push master to do that. From the link to the parent commit and the discussion here on GitHub it should be sufficiently clear from the context what's going on.

@elfring
Copy link
Author

elfring commented Oct 25, 2014

I hope that a better understanding will spread more around for CMake developers.

Thanks for your improvement of the build scripts.

@karlrupp
Copy link
Collaborator

Well, thank you for bringing the issue up and having a sharp eye for fixing it :-)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants