-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete quoting for parameters of some CMake commands #63
Comments
Thanks for the hint, we will fix this for the next release. |
It seems that there are a few more corrections needed in the affected build scripts. |
Thanks for the comments, I'll integrate your suggestions. |
I went over the previous changeset and removed the double quotes from all list variables. Thanks for the input, @elfring ! |
I find that your wording "all list variables" has got a high potential for misunderstandings. |
It's too late now for updating the wording, as I would have to force-push master to do that. From the link to the parent commit and the discussion here on GitHub it should be sufficiently clear from the context what's going on. |
I hope that a better understanding will spread more around for CMake developers. Thanks for your improvement of the build scripts. |
Well, thank you for bringing the issue up and having a sharp eye for fixing it :-) |
Some parameters (like "${PROJECT_SOURCE_DIR}" and "${DOXYGEN_EXECUTABLE}") are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like spaces.
I would recommend to apply advices from a Wiki article.
The text was updated successfully, but these errors were encountered: