Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make code for referrals unique #201

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Conversation

samhwang
Copy link
Collaborator

Description

This will introduce a DB migration to make the referral codes field unique. Although this may look simple, but the merge process will be difficult since it involves another script to dump out all of the referral code, check for duplicate and then re-insert into the table without disrupting the flow.

Motivation and Context

This will resolve #117

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@samhwang samhwang marked this pull request as draft February 16, 2024 23:34
@samhwang
Copy link
Collaborator Author

All referral codes has been exported, trimmed off the duplicates and re-inserted into Prod db.

@samhwang samhwang marked this pull request as ready for review February 17, 2024 08:49
@samhwang samhwang merged commit ea557d6 into master Feb 17, 2024
5 checks passed
@samhwang samhwang deleted the feat/177-referral-unique branch February 17, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant