Yet another dark color scheme for vifm added.

[clausED]

SemiDarkDesert,
based on 'Desert' by Michael jubalh Vetter (by Claus E. Durst, https://github.com/clausED/vifm-colors)

[clausED]

I am very new to GitHub and hope that I didn't make any mistakes with the procedure or crossed any rules ;)

[jubalh]

All fine except that you closed that pull request again :)
If you create a new one you can comment on it but shouldnt close it, since this signalizes that you don't want your stuff merged or similar.

So do I guess right that I can pull the changes in?

[clausED]

Hello Michael, thank you very much for your reply, and please apologise for that silly mistake. Reading manuals would in most cases avoid such things to happen ;) I never wanted to signal that I dislike stuff getting merged. I will find out if it is possible to reopen the pull request again. If so, I will do this next time I log in. Of course you can pull the changes in, thank you for doing this. Greetings, Claus.

…

On 23 February 2017 at 19:04, Michael Vetter ***@***.***> wrote: Reopened #13 <#13>. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#13 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARMtQNQ9eHtMxFiKpEgxRLRy3aCxShjuks5rfcoygaJpZM4MKKv_> .

[jubalh]

Hi Claus,

I reopened the pull request already.

And just saw now that you created a new repo and put your color theme in there, then created a pull request from it to vifm/vifm-colors.

Actually what you should do is:

• first backup you theme file somewhere, then remove your vifm-colors repo on GitHub
• fork the vifm-colors repo - go to https://github.com/vifm/vifm-colors/ and dlick on Fork GitHub will then create https://github.com/claused/vifm-colors/ for you which will already have content (the content from the original repo).
• add your file - now you put your scheme in that folder and run git add semidarkdesert.vifm and git commit -m "Add semidarkdesert theme" to add the file and commit it to your local repo
• push to your GitHub repo - now you run git push to push to your repo at https://github.com/claused/vifm-colors
• now you go to this website and click on new pull request

Thats it mostly.
It might be helpful to read the following:

• https://help.github.com/articles/fork-a-repo/ or https://guides.github.com/activities/forking/
• https://help.github.com/articles/about-pull-requests/
• https://help.github.com/articles/creating-a-pull-request-from-a-fork/
• https://help.github.com/articles/creating-a-pull-request/

Hope this helps

[xaizek]

@jubalh, he already has a proper fork called vifm-colors-1, from which this pull request was made. I don't think one can send pull request from not a fork, vifm-colors was probably a first try, which didn't work because of this.

[xaizek]

Merged manually in 5e38f7e. Thanks!