Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onedark theme #28

Merged
merged 5 commits into from
Mar 21, 2020
Merged

Add onedark theme #28

merged 5 commits into from
Mar 21, 2020

Conversation

mroavi
Copy link
Contributor

@mroavi mroavi commented Mar 21, 2020

image

Relies on the following terminal 16-color palette:

colors:
  # Default colors
  primary:
    background: '0x282C34'
    foreground: '0xABB2BF'
  # Normal colors
  normal:
    black:   '0x5C6370'
    red:     '0xE06C75'
    green:   '0x98C379'
    yellow:  '0xE5C07B'
    blue:    '0x61AFEF'
    magenta: '0xC678DD'
    cyan:    '0x56B6C2'
    white:   '0xABB2BF'
  # Bright colors
  bright:
    black:   '0x4B5263'
    red:     '0xBE5046'
    green:   '0x98C379'
    yellow:  '0xD19A66'
    blue:    '0x61AFEF'
    magenta: '0xC678DD'
    cyan:    '0x56B6C2'
    white:   '0x3E4452'

I used the gruvbox theme as template.

onedark.vifm Outdated
@@ -0,0 +1,30 @@
" gruvbox color scheme approximation for vifm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe you want to change this description comment here

onedark.vifm Outdated
highlight TopLineSel cterm=bold ctermfg=002 ctermbg=015

highlight Win cterm=none ctermfg=250 ctermbg=default
"highlight OtherWin cterm=none ctermfg=223 ctermbg=236
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you dont need this instead of commenting it out we could also remove the line entirely

Copy link
Contributor Author

@mroavi mroavi Mar 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That line is originally commented out in the gruvbox theme. It might be a good idea to remove it from there as well.

@jubalh
Copy link
Member

jubalh commented Mar 21, 2020

Looking good! Thanks!
I made two comments, will merge once addressed :)

@mroavi
Copy link
Contributor Author

mroavi commented Mar 21, 2020

By the way, how can I visualize the JobLine? I still need to update this value but I can't see where it is displayed.

@xaizek
Copy link
Member

xaizek commented Mar 21, 2020

how can I visualize the JobLine?

You can do

set deleteprg='sleep 10 #'

and then :delete! & on some file which won't actually be deleted.

@mroavi
Copy link
Contributor Author

mroavi commented Mar 21, 2020

Ahh perfect. Let me update it and then it will be ready.

@mroavi
Copy link
Contributor Author

mroavi commented Mar 21, 2020

All set now.

Do not color the border. Looks much better when vifm is used as a file
selector pane in `only` mode. The `gruvbox` theme does the same.
@jubalh jubalh self-requested a review March 21, 2020 18:12
@jubalh jubalh merged commit a4c0a39 into vifm:master Mar 21, 2020
@jubalh
Copy link
Member

jubalh commented Mar 21, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants